Skip to content

[feat][backend]: openclaw_trace#457

Open
cuichen01 wants to merge 18 commits intomainfrom
ft_cc_openclaw_trace
Open

[feat][backend]: openclaw_trace#457
cuichen01 wants to merge 18 commits intomainfrom
ft_cc_openclaw_trace

Conversation

@cuichen01
Copy link
Copy Markdown
Collaborator

What type of PR is this?

Check the PR title

  • This PR title match the format: [<type>][<scope>] <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese

(Optional) More detailed description for this PR(en: English/zh: Chinese)

en:
zh(optional):

(Optional) Which issue(s) this PR fixes

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 13, 2026

Codecov Report

❌ Patch coverage is 91.22807% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ckend/modules/observability/application/openapi.go 96.15% 1 Missing ⚠️
...ty/infra/mq/consumer/autotask_callback_consumer.go 0.00% 1 Missing ⚠️
...servability/infra/mq/consumer/backfill_consumer.go 0.00% 1 Missing ⚠️
...rvability/infra/mq/consumer/correction_consumer.go 0.00% 1 Missing ⚠️
...infra/mq/consumer/span_with_annotation_consumer.go 0.00% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #457      +/-   ##
==========================================
+ Coverage   75.68%   75.70%   +0.02%     
==========================================
  Files         640      641       +1     
  Lines       68796    68806      +10     
==========================================
+ Hits        52065    52090      +25     
+ Misses      13455    13447       -8     
+ Partials     3276     3269       -7     
Flag Coverage Δ
unittests 75.70% <91.22%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...bservability/domain/trace/service/trace_service.go 87.07% <100.00%> (+0.22%) ⬆️
...rvability/infra/mq/consumer/annotation_consumer.go 57.14% <100.00%> (+1.58%) ⬆️
...s/observability/infra/mq/consumer/task_consumer.go 100.00% <100.00%> (ø)
...a/span_context_extractor/span_context_extractor.go 100.00% <100.00%> (ø)
...ckend/modules/observability/application/openapi.go 84.22% <96.15%> (+0.84%) ⬆️
...ty/infra/mq/consumer/autotask_callback_consumer.go 0.00% <0.00%> (ø)
...servability/infra/mq/consumer/backfill_consumer.go 0.00% <0.00%> (ø)
...rvability/infra/mq/consumer/correction_consumer.go 0.00% <0.00%> (ø)
...infra/mq/consumer/span_with_annotation_consumer.go 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a0f249...b08ca47. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

if err != nil {
return nil, err
}
logTraceFilter := &loop_span.FilterFields{
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是不是不要做那么多处理了,就把logid, traceid, filter扔到processor里去。在processor里再去处理

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK,已放到下层

return &ListSpansResp{Spans: loop_span.SpanList{}}, nil
}
filters := r.combineFilters(builtinFilter, req.Filters)
filterJSON, err := json.MarshalString(filters)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

SpanDoubleCheck bool
QueryTraceID string
QueryLogID string
QueryFilterJSON string
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

直接就用FilterFields?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants