fix: Prevent fallback to existing jobs index #2644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BundleMonFiles updated (1)
Unchanged files (46)
Total files change +14B 0% Final result: ✅ View report in BundleMon website ➡️ |
Merkur39
approved these changes
Apr 5, 2023
The in-progress jobs query for the export feature relies on the presence of a very specific index to be fast on cozies with a lot of `io.cozy.jobs` documents. To make sure the index presence detection goes well, we forced a sort on the `worker` attribute. However, since `cozy-stack` uses an index on `worker` and `state` only, CouchDB fallbacks to this index instead of detecting the index we want does not exist and runs the slow `$or` query in-memory. See apache/couchdb#4511 for more details on this issue. To prevent this fallback we will sort on a second attribute not present in the existing `cozy-stack` index: `message.slug`.
taratatach
force-pushed
the
fix/avoid-fallback-to-existing-jobs-index
branch
from
97ebd8b
to
b9ef628
Compare
taratatach
added a commit
that referenced
this pull request
Apr 5, 2023
Backport of #2644 The in-progress jobs query for the export feature relies on the presence of a very specific index to be fast on cozies with a lot of `io.cozy.jobs` documents. To make sure the index presence detection goes well, we forced a sort on the `worker` attribute. However, since `cozy-stack` uses an index on `worker` and `state` only, CouchDB fallbacks to this index instead of detecting the index we want does not exist and runs the slow `$or` query in-memory. See apache/couchdb#4511 for more details on this issue. To prevent this fallback we will sort on a second attribute not present in the existing `cozy-stack` index: `message.slug`. ``` ### 🐛 Bug Fixes * Prevent fallback on sub-optimal index for in-progress jobs query. ```
taratatach
added a commit
that referenced
this pull request
Apr 5, 2023
Backport of #2644 The in-progress jobs query for the export feature relies on the presence of a very specific index to be fast on cozies with a lot of `io.cozy.jobs` documents. To make sure the index presence detection goes well, we forced a sort on the `worker` attribute. However, since `cozy-stack` uses an index on `worker` and `state` only, CouchDB fallbacks to this index instead of detecting the index we want does not exist and runs the slow `$or` query in-memory. See apache/couchdb#4511 for more details on this issue. To prevent this fallback we will sort on a second attribute not present in the existing `cozy-stack` index: `message.slug`. ``` ### 🐛 Bug Fixes * Prevent fallback on sub-optimal index for in-progress jobs query. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The in-progress jobs query for the export feature relies on the
presence of a very specific index to be fast on cozies with a lot of
io.cozy.jobsdocuments.To make sure the index presence detection goes well, we forced a sort
on the
workerattribute.However, since
cozy-stackuses an index onworkerandstateonly, CouchDB fallbacks to this index instead of detecting the index
we want does not exist and runs the slow
$orquery in-memory.See apache/couchdb#4511 for more details on
this issue.
To prevent this fallback we will sort on a second attribute not present
in the existing
cozy-stackindex:message.slug.