fix: Document has to be wrap into a data object to update instance #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cballevre
requested review from
Crash--,
Merkur39 and
paultranvan
as code owners
cballevre
force-pushed
the
fix/update-settings-instance
branch
from
6c2f002
to
012b093
Compare
Crash--
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we tried to update
io.cozy.settings.instance, the stack returns 409 errors to indicate conflicts. The problem was that we were sending the document directly, whereas the stack was looking for the document information in a data object (cf: PUT /settings/instance). Now, thecozy-stack-clientwraps the document in a data object before sending it.This fix has two benefits in
cozy-setting: