feat: Add ttl & password parameters in getSharingLink
#1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merkur39
force-pushed
the
feat/Upgrade-getSharingLink
branch
from
3d18cac to
3f5ca50
Compare
paultranvan
approved these changes
Nov 29, 2023
I added a commit with this change! |
Merkur39
force-pushed
the
feat/Upgrade-getSharingLink
branch
3 times, most recently
from
d37697d to
7e2eb8f
Compare
BREAKING CHANGE: The client already carries this information, if need to change this value, please update the client.
`getSharingLink` evolves, in order to offer more
configuration options on the sharing link,
two new parameters in an options object are added.
- `ttl`(optional): Allows you to define a duration before the link
expires (bigduration format, e.g. "4Y3M2D1h30m15s")
- `password`(optional): New functionality,
the generated link will return to a page requesting
this password before accessing the shared resource.
Example:
```
getSharingLink(client, filesIds, { ttl, password })
```
Merkur39
force-pushed
the
feat/Upgrade-getSharingLink
branch
from
7e2eb8f to
330b1ac
Compare
|
Hey @paultranvan, after discussion with @Crash-- I reviewed the implementation. |
Crash--
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
getSharingLinkevolves, in order to offer more configuration options on the sharing link, two new parameters are added (ttl&password), and its API is now an object.ttl(optional): Allows you to define a duration before the link expires (bigduration format, e.g. "4Y3M2D1h30m15s")password(optional): New functionality, the generated link will return to a page requesting this password before accessing the shared resource.Example: