feat: Add an icon in each qualifications by mapping [ver-398] #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will soon need new constants for adding icons on qualifications.
The future qualification modal in cozy-drive requires an icon for each qualification. As this is a purely UI requirement, we decided to add the `icon` attribute via a mapping and not directly to the `qualifications.json` file.
Crash--
approved these changes
Apr 2, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pour les besoin de la future modale de qualification dans cozy-drive, nous avons besoin que chaque qualification aient une icône associée.
Etant un besoin purement UI, il a été décidé d'ajouter l'attribut
iconvia un mapping et non directement le fichierqualifications.json.