feat: We don't want to concatenate additionalName in the displayName
#1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crash--
reviewed
Apr 2, 2024
| 'familyName', | ||
| 'nameSuffix' | ||
| ] | ||
| return ['namePrefix', 'givenName', 'familyName', 'nameSuffix'] |
There was a problem hiding this comment.
Tu parles de displayName dans la PR mais tu changes le makeFullName. Y a des endroits où le additionalName pourrait être utile dans le fullName. (genre si tu veux récupérer tous les prénoms d'un français ou ce genre de chose). Du coup pourquoi ne pas changer la méthode displayName ?
There was a problem hiding this comment.
Je me suis trompé dans mon titre de commit, je vais reformuler.
Ca ne change pas la pertinence de ta question, pour y répondre je viens de pousser une nouvelle approche.
je ne suis pas convaincu du nom de l'option attributesFullname, mais sinon l'approche me parait viable.
Merkur39
changed the title
additionalName in the displayNameadditionalName in the makeDisplayName
Merkur39
changed the title
additionalName in the makeDisplayNameadditionalName in the displayName
This attribute will be used within cozy-contacts. In this case, we do not want to concatenate in the `displayName` attribute the `additionalName` attribute. A simple solution is to offer the possibility to `makeFullname` to construct the `displayName` in a personalized way (within the limits of the attributes existing in `name`)
Crash--
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attribute will be used within cozy-contacts.
In this case, we do not want to concatenate in the
displayNameattribute theadditionalNameattribute.A simple solution is to offer the possibility to
makeFullnameto construct thedisplayNamein a personalized way (within the limits of the attributes existing inname)