[VO-711] feat: Add a collection to access files into a Nextcloud #1471
Conversation
cballevre
changed the title
To use the enabled option, the definition is passed in the form of a general function. I've adapted the typing to this practice. This allows me to display the warning also for definition passed with a function
| path: `${path}${path.endsWith('/') ? '' : '/'}${file.attributes.name}`, | ||
| cozyMetadata: { | ||
| ...file.attributes.cozyMetadata, | ||
| sourceAccount |
There was a problem hiding this comment.
Why do we have to manually set the sourceAccount? I feel like this should be up to the client to set it, just like the other cozyMetadata attributes?
There was a problem hiding this comment.
This is for convenience, because in order to use all the routes in the stack we need to have the Nextcloud path and sourceAccount pair. This is only present in the shortcut describing the Nextcloud. To reuse the same action as the io.cozy.files, I've introduced it into the file so that you only have to pass a file as a parameter as expected
| @@ -51,7 +51,7 @@ const useQuery = (queryDefinition, options) => { | |||
|
|
|||
| const client = useClient() | |||
| const queryState = useSelector(() => { | |||
| if (options.singleDocData === undefined && queryDefinition.id) { | |||
| if (options.singleDocData === undefined && definition?.id) { | |||
There was a problem hiding this comment.
Thanks to typing, yet another example, even with JSDoc
| const normalizeNextcloudFile = (sourceAccount, path) => file => { | ||
| const extendedAttributes = { | ||
| ...file.attributes, | ||
| path: `${path}${path.endsWith('/') ? '' : '/'}${file.attributes.name}`, |
There was a problem hiding this comment.
The stack does not return the path like the other files?
There was a problem hiding this comment.
Nop, but maybe she could do it
There was a problem hiding this comment.
I feel like it should for consistency, @nono what do you think?
There was a problem hiding this comment.
Well, it makes the response bigger, and they are quite easy to compute client-side, so I decided to not include them.
This PR is the first one to implement the new type
io.cozy.remote.nextcloud.files. It allow us to interact with Nextcloud server inside Drive 🙂Related PRs :