feat: Add support for io.cozy.bills in models/paper #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 27, 2024
Merkur39
approved these changes
May 28, 2024
| @@ -48,6 +48,7 @@ export const KNOWN_INFORMATION_METADATA_NAMES = [ | |||
| 'noticePeriod' | |||
| ] | |||
| export const KNOWN_OTHER_METADATA_NAMES = ['contact', 'page', 'qualification'] | |||
| export const KNOWN_BILLS_METADATA_NAMES = ['amount', 'subtype', 'employer'] | |||
There was a problem hiding this comment.
I don't know if it would be better to call it KNOWN_BILLS_ATTRIBUTE_NAMES, rather than sounding like the other “KNOWN_...” names. 🤔
There was a problem hiding this comment.
oui très bonne remarque, je me suis dit la même chose Le mot "metadata" prête un peu à confusion, car finalement tout attribut d'un doc est une metadata 🤔 C'est peut-être plus sage de faire la distinction 👍
zatteo
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.