[VO-874] feat: Improve index naming

[cballevre]

Index naming has two weaknesses:

• it doesn't include partial index values

This can cause differences between the expected result and the result when modifying queries.

An example of the new index name:

Query definition :

Q('io.cozy.files')
  .where({
    type: 'file',
  })
  .partialIndex({
    class: {
      $or: ['image', 'pdf'] 
    }
    trashed: {
      $eq: false 
    }
  })
  .sortBy([
    { name: 'desc' }
  ])

Old index name : _design/by_type_and_name_filter_class_and_trashed
New index name : _design/by_type_and_name_filter_(class_(image_$or_pdf))_and_(trashed_$eq_false)

[paultranvan]

That's a really great and long-expected work, thank you @cballevre!
My main concern is about the explicit operators, I feel like at least one of your test is not working at it should on couchdb. We might need to push tests a bit further, directly on couchdb

[paultranvan]

Have you tested this one on couchdb? I don't think that would work like this, I would expect this from couchdb:

  "$or": [
    {
      "type": {
        "$eq": "konnector"
      }
    },
    {
      "type": {
        "$eq": "worker"
      }
    }
  ]

[cballevre]

Well found it was a failure. I've corrected the function to take this case into account 🙂

[paultranvan]

Everything looks good, but it's probably worth to make some real partial filter testing on couchdb, to ensure we didn't miss anything like the one with the $or

[paultranvan]

Related to #1374

[Crash--]

So much cleaner than what I did before 👏 👏

Since you have changed the index name, you're going to have a pretty heavy DB server load when you release an app with this (mainly app with services ;))

In fact you're just going to update the name of the index, it should be ok.

[Crash--]

You didn't change the method for the Pouch Link. Is it wanted? Is it out of scope ?

[paultranvan]

Since @Ldoppea is currently heavily working on pouch link and notably on this part, we didn't feel the need to put it in this PR scope. But this is indeed identified 😉
It also raises a question about the need the mutualize such parts between stack-client and pouch-link... Maybe a new CC package?

[paultranvan]

Since you have changed the index name, you're going to have a pretty heavy DB server load when you release an app with this (mainly app with services ;))

Since we migrate the existing index through a copy, we should avoid a too much consequent load (i.e. we don't recompute index)

[Crash--]

Yep, I updated my comment just before yours ;).

Just a last thing: I know that we had conflicts between the sack and cozy-client about index name. A few users had blank page because of this. I think that stack use partialFilters on some place, I'll double check that ;).

[paultranvan]

A few users had blank page because of this. I think that stack use partialFilters on some place, I'll double check that ;).

If you find any info about this, that would be precious!