fix: Applies PRs change requests for Offline mode #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 4, 2024
Ldoppea
changed the title
Ldoppea
force-pushed
the
fix/offline_reviews_feedbacks
branch
2 times, most recently
from
ded3440 to
67db2ab
Compare
Ldoppea
changed the title
Ldoppea
force-pushed
the
feat/download_files_flagship
branch
from
7b1ae64 to
ce57209
Compare
Base automatically changed from
feat/download_files_flagship
to
feat/meta_offline
September 9, 2024 13:50
In order to prevent implementation errors, we want to check that storageEngine implements the correct methods This replies to #1483 (comment)
We want to extract this code logic into its own method in order to ease readability and testing Also we refactored the code to make it easier to read This replies to #1506 (comment)
This replies to #1486 (comment)
This commit is a copy of #1517 applied to CozyPouchLink When specifying fields in a query, e.g. `Q('io.cozy.todos').where({done: true}).select(['date'])`, the revision was missing if not explicitly given. This is now problematic because we rely on the revision existence to identify "virtual" documents, i.e. not persisted in CouchDB, that never have any revision. See #1486 for more insights.
With CouchDB, it is possible to make a mango query on an index without having any predicate on an sorted field in the selector It is not possible with PouchDB that requires to have any sorted fields to be in the selector We automatically handle that to avoid breaking existing queries
This guard has been added to handle documents with no `meta.rev` but since we added a check on `_rev` (in addition to `meta.rev`) to trigger the persistence, then we don't need this guard anymore This replies to #1486 (comment) Related commit: b797eb3 Related commit: 62290ed
Previous implementation was from a misunderstanding of CozyPouchLink mechanisms As we don't need to specify warmup queries in CozyPouchLink instanciation, we don't need the `ignoreWarmup` as we would result to the same behavior of having no warmup queries Warmup queries concept is meant to be removed into the future as we won't be able to use them when offline and the scenario that needed them (cozy-banks and cozy-drive apps) does not exist anymore This replies to #1506 (comment) Related commit: bb43ae9
Ldoppea
force-pushed
the
fix/offline_reviews_feedbacks
branch
from
67db2ab to
ce86492
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies change requests from previous PRs on Offline mode
See all commit messages for more details
Related PRs: