Merge pull request #215 from cozy/feat/sort-login-before

feat: Logins before every other types in search result

libs/common/src/services/search.service.ts

@@ -109,7 +109,10 @@ export class SearchService implements SearchServiceAbstraction {
     filter: ((cipher: CipherView) => boolean) | ((cipher: CipherView) => boolean)[] = null,
     ciphers: CipherView[] = null
   ): Promise<CipherView[]> {
+    // Cozy customization, display logins before every other types (see below)
+    /*
     const results: CipherView[] = [];
+    */
     if (query != null) {
       query = SearchService.normalizeSearchQuery(query.trim().toLowerCase());
     }
@@ -168,13 +171,35 @@ export class SearchService implements SearchServiceAbstraction {
       });
     }
 
+    // Cozy customization, display logins before every other types
+    // For example, it avoids to have 100 Free invoices before 1 Free login
+    //*
+    const loginResults: CipherView[] = [];
+    const otherResults: CipherView[] = [];
+
+    if (searchResults != null) {
+      searchResults.forEach((r) => {
+        if (ciphersMap.has(r.ref)) {
+          const cipher = ciphersMap.get(r.ref);
+          if (cipher.type === CipherType.Login) {
+            loginResults.push(cipher);
+          } else {
+            otherResults.push(cipher);
+          }
+        }
+      });
+    }
+
+    const results = loginResults.concat(otherResults);
+    /*/
     if (searchResults != null) {
       searchResults.forEach((r) => {
         if (ciphersMap.has(r.ref)) {
           results.push(ciphersMap.get(r.ref));
         }
       });
     }
+    //*/
     return results;
   }