Add a trigger for saving OO documents #3751
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a document is edited with OnlyOffice, the OnlyOffice server keeps a cache of the document and will send the document to save to the stack only if the user asks for a forcesave (ctrl-s shortcut), or after some time with no tab opened on the document. In our experience, it can be long and the users can expect the document to be saved to the VFS, and then synchronized via the sharings / desktop, but OO still has the document in its cache and doesn't send the save. So, we decided to add a new trigger that will ask the OO server to forcesave often to ensure a better synchronisation between OO and the Cozy.
taratatach
reviewed
Feb 16, 2023
| if err != nil { | ||
| return err | ||
| } | ||
| return sched.AddTrigger(t) |
There was a problem hiding this comment.
Shouldn't we check if a trigger already exists to avoid creating multiple triggers in case a document is opened in multiple tabs?
| if _, err := GetStore().GetDoc(inst, msg.Key); err != nil { | ||
| // By returning the ErrBadTrigger code, the stack will know that it | ||
| // must delete the trigger. | ||
| return job.ErrBadTrigger{Err: err} |
There was a problem hiding this comment.
Is this how the trigger will be removed once the user is done editing?
|
This PR has some strong drawbacks, and a new way has been prefered: #4138 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a document is edited with OnlyOffice, the OnlyOffice server keeps a cache of the document and will send the document to save to the stack only if the user asks for a forcesave (ctrl-s shortcut), or after some time with no tab opened on the document. In our experience, it can be long and the users can expect the document to be saved to the VFS, and then synchronized via the sharings / desktop, but OO still has the document in its cache and doesn't send the save.
So, we decided to add a new trigger that will ask the OO server to forcesave often to ensure a better synchronisation between OO and the Cozy.