fix: Import resolution problem inside Storybook of cozy-harvest #2715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cballevre
requested review from
JF-Cozy,
Merkur39,
Ldoppea and
zatteo
as code owners
BundleMonUnchanged files (3)
No change in files bundle size Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
|
🎉 This PR is included in version 113.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
JF-Cozy
reviewed
Nov 12, 2024
| * @property {string} [color] - The color of the text. | ||
| * @property {string} [variant] - The variant of the text. | ||
| * @property {React.ReactNode} children - The content of the component. | ||
| */ |
There was a problem hiding this comment.
on aurait peut-être pu mettre toutes les props... 🤔 https://v4.mui.com/api/typography/#typography-api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Storybook for Harvest could not resolve cozy-ui/react/ as it isn't present in the transpiled version. To resolve this, I updated the import to use relative paths consistently with the rest of the codebase. Additionally, as ShortcutTile is a TypeScript file, I needed typed versions of all components it relies on, so I added JSDoc to Typography to ensure compatibility.