Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove cordova stuff from AppLinker #2728

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zatteo
Copy link
Contributor

@zatteo zatteo commented Dec 13, 2024

No description provided.

Copy link

bundlemon bot commented Dec 13, 2024

BundleMon

Unchanged files (3)
Status Path Size Limits
dist/cozy-ui.min.css
20.23KB +10%
transpiled/react/stylesheet.css
16.93KB -
dist/cozy-ui.utils.min.css
10.91KB +10%

No change in files bundle size

Groups updated (1)
Status Path Size Limits
transpiled/react/**
667.98KB (-1.67KB -0.25%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@zatteo zatteo marked this pull request as draft December 13, 2024 16:23
@zatteo zatteo force-pushed the feat/clean-app-linker branch from db63679 to 7240f75 Compare December 17, 2024 10:00
@zatteo zatteo force-pushed the feat/clean-app-linker branch 3 times, most recently from 6a39f8b to b5d21f4 Compare January 6, 2025 14:42
@zatteo zatteo marked this pull request as ready for review January 6, 2025 15:27
@zatteo zatteo force-pushed the feat/clean-app-linker branch from f83a0ed to 62a0ae7 Compare January 7, 2025 08:27
react/AppLinker/index.jsx Outdated Show resolved Hide resolved
@zatteo zatteo force-pushed the feat/clean-app-linker branch 2 times, most recently from ae20883 to 674f4ed Compare January 7, 2025 16:29
zatteo added 3 commits January 8, 2025 10:47
BREAKING CHANGE: Use app={{ slug: 'drive' }} instead of slug='drive' as
AppLinker prop. Also, `name` is not passed anymore as render prop.
@zatteo zatteo force-pushed the feat/clean-app-linker branch from 45b9cfc to 3c676d9 Compare January 8, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants