Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings Modal is Displacing when going through tabs #156

Closed
devishraq opened this issue Aug 6, 2024 · 7 comments · Fixed by #157
Closed

Settings Modal is Displacing when going through tabs #156

devishraq opened this issue Aug 6, 2024 · 7 comments · Fixed by #157
Assignees

Comments

@devishraq
Copy link
Contributor

devishraq commented Aug 6, 2024

Problem Description

When users open the settings modal and navigate through the tabs, specifically the Judge tab, the entire modal shifts. This issue is caused by the use of the overflow-y-auto class, which hides the scrollbar when on the Judge tab.

Simplistic Solution

The proposed solution is to set overflow-y: scroll; to ensure the scrollbar is always present, thereby preventing the displacement. Additionally, the scrollbar should be hidden but its functionality retained.

Uploading Screen-Recording-2024-08-06T08_23_21.970Z.mp4…

@devishraq
Copy link
Contributor Author

I think I would be able to solve this.....Any one please assign me this!

@devishraq
Copy link
Contributor Author

@thecodingwizard! Which approach will be much better removing the scrollbar while the settings modal is opened but keeping scrolling functionalities or just using overflow-y: scroll?

The first approach will be better I think....

@thecodingwizard
Copy link
Member

Sorry could you re-upload the screen recording? I don't think it uploaded properly and I can't reproduce this issue on my end (though I'm on a mac).

The first approach is indeed better but I'm not actually sure how this can be done (maybe scrollbar width can be configured with CSS? not sure...)

@devishraq
Copy link
Contributor Author

devishraq commented Aug 7, 2024

@thecodingwizard I am unable to upload it here....I don't why!....But here is a link from jumpshare:-
https://jumpshare.com/s/sLqkXGVLViKLRES3wTYu

@devishraq
Copy link
Contributor Author

devishraq commented Aug 7, 2024

Here you can see : I forked, cloned, and edited and the result:-
https://jmp.sh/s/ChCcddzt0nJtzF1oZ1KT
I have taken the first approach as it may slightly improve the cleanliness of the UI!

@devishraq
Copy link
Contributor Author

@thecodingwizard ! can you check the videos and the pull request kindly?

@thecodingwizard
Copy link
Member

Closed via #157 , thank you @devishraq !

@thecodingwizard thecodingwizard linked a pull request Aug 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants