fix for settings-modal displacement #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nality - Added .no-scrollbar class to hide the scrollbar - Changed tailwindcss class from overflow-y-auto to overflow-y-scroll in settings modal - Updated settings modals.tsx and globals.css This ensures the modal remains in place when switching between tabs with different content heights.
|
@devishraq is attempting to deploy a commit to the CP Initiative Team on Vercel. A member of the Team first needs to authorize it. |
|
@thecodingwizard ! Can you have a look? |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thecodingwizard
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR hides the scrollbar in the settings modal while preserving the scroll functionality. This change ensures that the modal remains in place when switching between tabs with different content heights.
Changes
.no-scrollbarclass to hide the scrollbar.overflow-y-autotooverflow-y-scrollin the settings modal.SettingsModal.tsxandglobals.css.Testing
Related Issues
Fixes issue #156