Autogenerated filename

[AsynchronousAI]

#97

[vercel]

@AsynchronousAI is attempting to deploy a commit to the CP Initiative Team on Vercel.

A member of the Team first needs to authorize it.

[thecodingwizard]

nice! a couple minor things:

• placeholder should be applied to the input, not to the label
• right now, every rerender will change the placeholder. maybe make defaultFileName a state, and add a useEffect to set the default file name once when the component is mounted.
• you'll need to modify the handleSubmit function to use the defaultFileName if fileName is an empty string.

[AsynchronousAI]

• placeholder should be applied to the input, not to the label

That's my bad, sorry.

• right now, every rerender will change the placeholder. maybe make defaultFileName a state, and add a useEffect to set the default file name once when the component is mounted.
• you'll need to modify the handleSubmit function to use the defaultFileName if fileName is an empty string.

I switched everything to set the fileName state to a random fileName rather than having it directly display random so it should fix these 2 issues.

[AsynchronousAI]

Also I was having trouble with npm run dev is there a setup guide?

[thecodingwizard]

Instructions are here, though they're not that thorough: https://github.com/cpinitiative/ide?tab=readme-ov-file#running-locally

What issue were you having?

[AsynchronousAI]

Instructions are here, though they're not that thorough: https://github.com/cpinitiative/ide?tab=readme-ov-file#running-locally

What issue were you having?

My server was incorrectly setup.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ide	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 10, 2024 8:38pm

[thecodingwizard]

I think it may make more sense to move src/fileName.ts to src/scripts/generateRandomFileNamets, keep it as export default generateRandomFileName, and change the import to not have the curly braces (ie. import generateRandomFileName from .... Open to other ideas though!

To get the current code working, you have to remove "default" from the "export default ...". Or, remove the curly braces from import { generateRandomFileName }.

Thanks for making this PR!

[AsynchronousAI]

I think it may make more sense to move src/fileName.ts to src/scripts/generateRandomFileNamets, keep it as export default generateRandomFileName, and change the import to not have the curly braces (ie. import generateRandomFileName from .... Open to other ideas though!

To get the current code working, you have to remove "default" from the "export default ...". Or, remove the curly braces from import { generateRandomFileName }.

Thanks for making this PR!

I made it so that the file name generator is in the new.tsx file itself just to avoid file abundance, I also only added like 15 adjetives and 15 nouns so the file doesn't get too large.

[thecodingwizard]

Hmm, I think after the auto-formatter makes every word its own line, it can get kind of big (and potentially we may want to add more words later). It might still be better to move it to a separate file outside of new.tsx?

(Sorry for making so many requested changes 😅)

[AsynchronousAI]

Hmm, I think after the auto-formatter makes every word its own line, it can get kind of big (and potentially we may want to add more words later). It might still be better to move it to a separate file outside of new.tsx?

Fixed, I used src/scripts/generateFileName.ts.

(Sorry for making so many requested changes 😅)

No problem!

[AsynchronousAI]

@thecodingwizard?

[danielzsh]

Make sure to re-request reviews after implementing changes, with the little gray cycle button 😅

[thecodingwizard]

Sorry for the delay, completely missed this 😰 . lgtm other than one minor fix. Thanks!

[thecodingwizard]

lgtm if ci checks pass!

[AsynchronousAI]

Tested it out also here, it works.

[thecodingwizard]

Awesome, thanks!!