Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactored] : Update cses 1634 condition and format Python section #4789

Merged
merged 5 commits into from
Sep 17, 2024
Merged

[Refactored] : Update cses 1634 condition and format Python section #4789

merged 5 commits into from
Sep 17, 2024

Conversation

amansharma07
Copy link
Contributor

Place an "x" in the corresponding checkbox if it is done or does not apply to this pull request.

  • I have tested my code.
  • I have added my solution according to the steps here.
  • I have followed the code conventions mentioned here.
    • I understand that if it is clear that I have not attempted to follow these conventions, my PR will be closed.
    • If changes are requested, I will re-request a review after addressing them.
  • I have linked this PR to any issues that it closes.

Proofs of AC :

C++ -
image

Java -
image

Python -
image

TheGamingMousse
TheGamingMousse reviewed Sep 16, 2024
View reviewed changes
Copy link
Contributor

@TheGamingMousse TheGamingMousse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! while at it, could you please detemplate the C++ code? (like, remove the setio and all the unnecessary macroes and stuff)

@amansharma07
Copy link
Contributor Author

Updated

@TheGamingMousse
Copy link
Contributor

Updated

i would personally remove the using vi = vector thing, and also i don’t think casting 1e9 is needed. good work tho!

@amansharma07
Copy link
Contributor Author

Updated

i would personally remove the using vi = vector thing, and also i don’t think casting 1e9 is needed. good work tho!

Done now

@SansPapyrus683 SansPapyrus683 merged commit 23b3bb4 into cpinitiative:master Sep 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SansPapyrus683 SansPapyrus683 SansPapyrus683 approved these changes

@TheGamingMousse TheGamingMousse TheGamingMousse approved these changes

@dongliu0426 dongliu0426 Awaiting requested review from dongliu0426 dongliu0426 is a code owner

@envyaims envyaims Awaiting requested review from envyaims envyaims is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amansharma07 @TheGamingMousse @SansPapyrus683