Skip to content

Conversation

@eisenwave
Copy link
Member

@eisenwave eisenwave commented Oct 9, 2025

Fixes https://github.com/cplusplus/nbballot/issues/891.

The parameter indentation in the subclause is broken in four different ways:

  • In the first block with exchange, fetch_max, etc. it looks like constexpr was added without adding then necessary indentation to the second line of the declaration, resulting in misalignment.
  • For store_fmaximum and some others, an attempt was made to align the parameters, but unsuccessfully.
  • In the definition of fetch_key, there is one space too much indentation, and we forgot to use placeholdernc rather than placeholder.
  • In the definition of store_key, we just used two-space indentation rather than trying to align parameters at all.

@eisenwave eisenwave added the ballot-comment Response to an NB or ISO comment on a ballot label Oct 9, 2025
@tkoeppe
Copy link
Contributor

tkoeppe commented Oct 31, 2025

Perfect, thanks!

@tkoeppe tkoeppe merged commit bdf2d63 into cplusplus:main Oct 31, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ballot-comment Response to an NB or ISO comment on a ballot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants