[lib] Remove superfluous typename in alias declarations
#8371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensmaurer
force-pushed
the
c81
branch
2 times, most recently
from
f0ab521 to
7697a93
Compare
jensmaurer
changed the title
typename in alias declarations
Contributor
|
I have performed a visual inspection of the PR and can confirm all changes look correct, and there are no line-wrapping issues where removing a I have not yet gone looking for potential missing cases, such as |
jwakely
approved these changes
Oct 27, 2025
Contributor
|
This would be good to land before Kona so that wording reviews have the right base, although I am sure that Jonathan and Jeff will cope regardless. |
Contributor
|
@AlisdairM This needs to be rebased I'm afraid. |
tkoeppe
added
the
needs rebase
This comment was marked as resolved.
This comment was marked as resolved.
jensmaurer
removed
the
needs rebase
Also add an automatic check. Fixes NB US 64-127 (C++26 CD).
Member
Author
|
@tkoeppe , rebased and added the change mentioned in #8371 (comment) |
jwakely
approved these changes
Oct 31, 2025
Contributor
|
Great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes NB US 64-127 (C++26 CD).
Also add an automatic check.
Fixes cplusplus/nbballot#706