Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] skip IC from MACS toolbox for octave for now #1224

Merged
merged 10 commits into from
Apr 9, 2024

Conversation

Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Apr 8, 2024

  • should at least allow bidspm stats to octave on octave until things are fixed upstream

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Remi-Gau - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Docstrings: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.33%. Comparing base (f53979a) to head (2c33d30).
Report is 65 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1224       +/-   ##
===========================================
- Coverage   79.57%   38.33%   -41.24%     
===========================================
  Files         285        4      -281     
  Lines        7742      253     -7489     
  Branches       40       40               
===========================================
- Hits         6161       97     -6064     
+ Misses       1565      140     -1425     
  Partials       16       16               
Flag Coverage Δ
cli 38.33% <ø> (-0.66%) ⬇️
macos-latest_matlab-R2023a_fast ?
macos-latest_matlab-R2023a_slow ?
octave ?
ubuntu-latest_matlab-R2023a_fast ?
ubuntu-latest_matlab-R2023a_slow ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Remi-Gau Remi-Gau merged commit 4de9f55 into cpp-lln-lab:main Apr 9, 2024
29 of 32 checks passed
@Remi-Gau Remi-Gau deleted the fix/IC_octave branch April 9, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant