fix test #1601

alex-Arc · 2025-05-01T21:32:47Z

the metadate is calculated as async so needs to be forced to run

coderabbitai · 2025-05-01T21:32:52Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

cpvalente

left a small suggestion for improvement

cpvalente · 2025-05-02T06:11:54Z

apps/server/src/stores/__tests__/runtimeState.test.ts

+      const currentOffset = getState().runtime.offset;
      let result = roll(rundown, rundown.order, getState().runtime.offset);
      expect(result).toStrictEqual({ eventId: '1', didStart: false });
-      expect(getState().runtime.offset).toBe(1000);
+      expect(getState().runtime.offset).toBe(currentOffset);


question: can you clarify why we are keeping the value of currentOffset and comparing it after the roll call?
Is the objective to make sure it didnt change?
If so: the name of the variable should be something like offsetBeforeRoll, we could also do with a small comment explaining that since it is not explicit in code

* fix test * add comment

This reverts commit 543b04a.

* Revert "refactor: add version to session endpoint" This reverts commit cd40a6e. * Revert "Remove public event feature (#1645)" This reverts commit 08d9e24. * Revert "Fix: rearrange playing event (#1640)" This reverts commit 0649678. * Revert "refactor: style tweaks to edit css modal" This reverts commit a00ec2d. * Revert "refactor: remove usages of framer-motion" This reverts commit 54a74cc. * Revert "Upgrade expressjs (#1633)" This reverts commit 6f3ab27. * Revert "Refactor: require trigger in all events objects (#1636)" This reverts commit 90870ec. * Revert "Fix: Correct boundary condition in applyDelay" This reverts commit b640e0e. * Revert "let vite be the proxy to the dev server (#1630)" This reverts commit c41fe82. * Revert "refactor: migrate custom fields to transactions" This reverts commit 62c8319. * Revert "refactor: simplify validations" This reverts commit b1d2346. * Revert "refactor: create transaction system and apply to adding entry (#1620)" This reverts commit 9a62daf. * Revert "Refactor: better rounding (#1594)" This reverts commit b9ab1c6. * Revert "refactor: improve reorder logic" This reverts commit c105471. * Revert "chore: simplify URLs" This reverts commit a4d4f29. * Revert "refactor: order is single source of truth" This reverts commit 2793aad. * Revert "refactor: refetch targets is enum" This reverts commit e7cfb7d. * Revert "refactor: small ux improvements" This reverts commit 256a851. * Revert "refactor: remove trivially inferred numEvents" This reverts commit 4ab9c81. * Revert "feat: duplicate groups" This reverts commit 2f13d6c. * Revert "feat: create group from entry selection" This reverts commit f1f7bad. * Revert "feat: create block from rundown empty" This reverts commit a8b52a4. * Revert "fix: collapsed blocks dont render children" This reverts commit cd0999b. * Revert "refactor: type cleanup and test improvements" This reverts commit b4c60f3. * Revert "feat: allow dissolving a block" This reverts commit 5cefad3. * Revert "fix: uncontrolled prop on controlled component" This reverts commit 7a6ecd8. * Revert "refactor: improve return of reorder" This reverts commit ba96ecf. * Revert "refactor: mutations on batch elements must have IDs" This reverts commit 7bed375. * Revert "chore: upgrade dependencies" This reverts commit e2e755b. * Revert "refactor: extract utility to merge two arrays" This reverts commit a77d231. * Revert "refactor: change network mode defaults" This reverts commit 0eb3b8d. * Revert "fix: delete nested events" This reverts commit 0021185. * Revert "fix: add event at end of block" This reverts commit 94c72ff. * Revert "refactor: make finder available in exported rundown" This reverts commit e4c08dc. * Revert "assert non null and update test (#1604)" This reverts commit ec74af0. * Revert "Fix project renumber (#1597)" This reverts commit b6d72dd. * Revert "Refactor: WebSocket from flush queue to one patch (#1595)" This reverts commit 31c311d. * Revert "Refactor: ms for api calls (#1593)" This reverts commit e9b3cc6. * Revert "fix test (#1601)" This reverts commit 543b04a. * Revert "fix: rebase master" This reverts commit d39b85b. * Revert "chore: correct test path" This reverts commit bbe107b. * Revert "refactor: extract rundown parsing" This reverts commit c616240. * Revert "chore: improve convention entry <> event" This reverts commit 166be66. * Revert "refactor: maintain flat orders" This reverts commit 4180d0a. * Revert "refactor: implement operations on nested events" This reverts commit 78108e3. * Revert "refactor: process events in rundown" This reverts commit 3bb8b70. * Revert "chore: improve convention entry <> event" This reverts commit 1c4f13a. * Revert "chore: rename currentBlock > parent" This reverts commit 3ca0aba. * Revert "refactor: fix delay positioning in gaps" This reverts commit 030c8f8. * Revert "refactor(e2e): skip flaky test" This reverts commit 68175cf. * Revert "refactor: improve project loading" This reverts commit fd8f757. * Revert "refactor: gather group metadata" This reverts commit 876d111. * Revert "refactor: swap maintains schedule" This reverts commit 730cb95. * Revert "chore: rename files" This reverts commit 3c388d4. * Revert "refactor: restructure model to contain an object of rundowns" This reverts commit 2e23718. * Revert "refactor: clearer relationship on rundown elements" This reverts commit 89ea8c4. * Revert "refactor: use strict typing" This reverts commit 178640b. * Revert "refactor: remove stop as a possible end action" This reverts commit 4ed3834. * Revert "refactor: restructure model to contain an object of rundowns" This reverts commit 69eb9a5. * Revert "chore: remove IDE files" This reverts commit 3514251. * Revert "refactor: remove unused and legacy code" This reverts commit 95f2ba3.

fix test

115b1c9

alex-Arc requested a review from cpvalente May 1, 2025 21:36

cpvalente approved these changes May 2, 2025

View reviewed changes

add comment

7e61376

alex-Arc merged commit f181c7f into v4 May 2, 2025
4 checks passed

alex-Arc deleted the fix-test branch May 2, 2025 17:30

cpvalente pushed a commit that referenced this pull request May 9, 2025

fix test (#1601)

a0231ae

* fix test * add comment

cpvalente pushed a commit that referenced this pull request May 14, 2025

fix test (#1601)

94b80d3

* fix test * add comment

cpvalente pushed a commit that referenced this pull request Jun 5, 2025

fix test (#1601)

4eb4f59

* fix test * add comment

alex-Arc added a commit that referenced this pull request Jun 8, 2025

fix test (#1601)

a572533

* fix test * add comment

alex-Arc added a commit that referenced this pull request Jun 9, 2025

fix test (#1601)

5c47a83

* fix test * add comment

cpvalente pushed a commit that referenced this pull request Jun 19, 2025

fix test (#1601)

543b04a

* fix test * add comment

alex-Arc added a commit that referenced this pull request Jun 20, 2025

Revert "fix test (#1601)"

48a42d5

This reverts commit 543b04a.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix test #1601

fix test #1601

Uh oh!

alex-Arc commented May 1, 2025

Uh oh!

coderabbitai bot commented May 1, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

cpvalente left a comment

Uh oh!

cpvalente May 2, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fix test #1601

fix test #1601

Uh oh!

Conversation

alex-Arc commented May 1, 2025

Uh oh!

coderabbitai bot commented May 1, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

cpvalente left a comment

Choose a reason for hiding this comment

Uh oh!

cpvalente May 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

CodeRabbit Configuration File (`.coderabbit.yaml`)