Remove exceptions printing stack traces (#1291)

cqframework · Nov 27, 2023 · 2985f47 · 2985f47
1 parent 0d5a670
commit 2985f47
Show file tree

Hide file tree

Showing 17 changed files with 14 additions and 90 deletions.
diff --git a/...java/cql-to-elm/src/main/java/org/cqframework/cql/cql2elm/CqlTranslatorOptionsMapper.java b/...java/cql-to-elm/src/main/java/org/cqframework/cql/cql2elm/CqlTranslatorOptionsMapper.java
@@ -13,7 +13,6 @@ public static CqlTranslatorOptions fromFile(String fileName) {
             fr = new FileReader(fileName);
             return fromReader(fr);
         } catch (IOException e) {
-            e.printStackTrace();
             throw new RuntimeException(String.format("Errors occurred reading options: %s", e.getMessage()));
         }
     }
@@ -22,7 +21,6 @@ public static CqlTranslatorOptions fromReader(Reader reader) {
         try {
             return om.readValue(reader, CqlTranslatorOptions.class);
         } catch (IOException e) {
-            e.printStackTrace();
             throw new RuntimeException(String.format("Errors occurred reading options: %s", e.getMessage()));
         }
     }
@@ -33,7 +31,6 @@ public static void toFile(String fileName, CqlTranslatorOptions options) {
             fw = new FileWriter(fileName);
             toWriter(fw, options);
         } catch (IOException e) {
-            e.printStackTrace();
             throw new RuntimeException(String.format("Errors occurred writing options: %s", e.getMessage()));
         }
     }
@@ -43,7 +40,6 @@ public static void toWriter(Writer writer, CqlTranslatorOptions options) {
         try {
             om.writeValue(writer, options);
         } catch (IOException e) {
-            e.printStackTrace();
             throw new RuntimeException(String.format("Errors occurred writing options: %s", e.getMessage()));
         }
     }

diff --git a/Src/java/cql-to-elm/src/main/java/org/cqframework/cql/cql2elm/DefaultModelInfoProvider.java b/Src/java/cql-to-elm/src/main/java/org/cqframework/cql/cql2elm/DefaultModelInfoProvider.java
@@ -102,7 +102,6 @@ public boolean accept(File path, String name) {
                     return ModelInfoReaderFactory.getReader("application/xml").read(is);
                 }
             } catch (IOException e) {
-                e.printStackTrace();
                 throw new IllegalArgumentException(String.format("Could not load definition for model info %s.", modelIdentifier.getId()), e);
             }
         }

diff --git a/Src/java/cql-to-elm/src/main/java/org/cqframework/cql/cql2elm/LibraryManager.java b/Src/java/cql-to-elm/src/main/java/org/cqframework/cql/cql2elm/LibraryManager.java
@@ -279,7 +279,7 @@ private CompiledLibrary generateCompiledLibraryFromElm(VersionedIdentifier libra
         try {
             library = ElmLibraryReaderFactory.getReader(type.mimeType()).read(new InputStreamReader(librarySource));
         } catch (IOException e) {
-            e.printStackTrace();
+            // intentionally ignored
         }
 
         if (library != null && checkBinaryCompatibility(library)) {

diff --git a/Src/java/elm-jaxb/src/main/java/org/cqframework/cql/elm/serializing/jaxb/ElmJsonMapper.java b/Src/java/elm-jaxb/src/main/java/org/cqframework/cql/elm/serializing/jaxb/ElmJsonMapper.java
@@ -15,7 +15,6 @@ public static JAXBContext getJaxbContext() {
             try {
                 jaxbContext = JAXBContext.newInstance(Library.class, CqlToElmBase.class);
             } catch (JAXBException e) {
-                e.printStackTrace();
                 throw new RuntimeException("Error creating JAXBContext - " + e.getMessage());
             }
         }

diff --git a/Src/java/elm-jaxb/src/main/java/org/cqframework/cql/elm/serializing/jaxb/ElmXmlMapper.java b/Src/java/elm-jaxb/src/main/java/org/cqframework/cql/elm/serializing/jaxb/ElmXmlMapper.java
@@ -1,8 +1,5 @@
 package org.cqframework.cql.elm.serializing.jaxb;
 
-import org.hl7.cql_annotations.r1.CqlToElmBase;
-import org.hl7.elm.r1.Library;
-
 import jakarta.xml.bind.JAXBContext;
 import jakarta.xml.bind.JAXBException;
 
@@ -15,7 +12,6 @@ public static JAXBContext getJaxbContext() {
             try {
                 jaxbContext = JAXBContext.newInstance(org.hl7.elm.r1.ObjectFactory.class, org.hl7.cql_annotations.r1.ObjectFactory.class);
             } catch (JAXBException e) {
-                e.printStackTrace();
                 throw new RuntimeException("Error creating JAXBContext - " + e.getMessage());
             }
         }

diff --git a/...gine-fhir/src/main/java/org/opencds/cqf/cql/engine/fhir/model/Dstu2FhirModelResolver.java b/...gine-fhir/src/main/java/org/opencds/cqf/cql/engine/fhir/model/Dstu2FhirModelResolver.java
@@ -91,18 +91,8 @@ protected void initialize() {
             Method m = this.fhirContext.getClass().getDeclaredMethod("scanResourceTypes", Collection.class);
             m.setAccessible(true);
             m.invoke(this.fhirContext, toLoad);
-        } catch (IllegalArgumentException e) {
-            e.printStackTrace();
-        } catch (NoSuchFieldException e) {
-            e.printStackTrace();
-        } catch (SecurityException e) {
-            e.printStackTrace();
-        } catch (IllegalAccessException e) {
-            e.printStackTrace();
-        } catch (NoSuchMethodException e) {
-            e.printStackTrace();
-        } catch (InvocationTargetException e) {
-            e.printStackTrace();
+        } catch (Exception e) {
+            // intentionally ignored
         }
     }
 

diff --git a/...gine-fhir/src/main/java/org/opencds/cqf/cql/engine/fhir/model/Dstu3FhirModelResolver.java b/...gine-fhir/src/main/java/org/opencds/cqf/cql/engine/fhir/model/Dstu3FhirModelResolver.java
@@ -92,18 +92,8 @@ protected void initialize() {
             Method m = this.fhirContext.getClass().getDeclaredMethod("scanResourceTypes", Collection.class);
             m.setAccessible(true);
             m.invoke(this.fhirContext, toLoad);
-        } catch (IllegalArgumentException e) {
-            e.printStackTrace();
-        } catch (NoSuchFieldException e) {
-            e.printStackTrace();
-        } catch (SecurityException e) {
-            e.printStackTrace();
-        } catch (IllegalAccessException e) {
-            e.printStackTrace();
-        } catch (NoSuchMethodException e) {
-            e.printStackTrace();
-        } catch (InvocationTargetException e) {
-            e.printStackTrace();
+        } catch (Exception e) {
+            // intentionally ignored
         }
     }
 

diff --git a/.../engine-fhir/src/main/java/org/opencds/cqf/cql/engine/fhir/model/R4FhirModelResolver.java b/.../engine-fhir/src/main/java/org/opencds/cqf/cql/engine/fhir/model/R4FhirModelResolver.java
@@ -92,18 +92,8 @@ protected void initialize() {
             Method m = this.fhirContext.getClass().getDeclaredMethod("scanResourceTypes", Collection.class);
             m.setAccessible(true);
             m.invoke(this.fhirContext, toLoad);
-        } catch (IllegalArgumentException e) {
-            e.printStackTrace();
-        } catch (NoSuchFieldException e) {
-            e.printStackTrace();
-        } catch (SecurityException e) {
-            e.printStackTrace();
-        } catch (IllegalAccessException e) {
-            e.printStackTrace();
-        } catch (NoSuchMethodException e) {
-            e.printStackTrace();
-        } catch (InvocationTargetException e) {
-            e.printStackTrace();
+        } catch (Exception e) {
+            // intentionally ignored
         }
     }
 

diff --git a/.../engine-fhir/src/main/java/org/opencds/cqf/cql/engine/fhir/model/R5FhirModelResolver.java b/.../engine-fhir/src/main/java/org/opencds/cqf/cql/engine/fhir/model/R5FhirModelResolver.java
@@ -96,19 +96,10 @@ protected void initialize() {
             Method m = this.fhirContext.getClass().getDeclaredMethod("scanResourceTypes", Collection.class);
             m.setAccessible(true);
             m.invoke(this.fhirContext, toLoad);
-        } catch (IllegalArgumentException e) {
-            e.printStackTrace();
-        } catch (NoSuchFieldException e) {
-            e.printStackTrace();
-        } catch (SecurityException e) {
-            e.printStackTrace();
-        } catch (IllegalAccessException e) {
-            e.printStackTrace();
-        } catch (NoSuchMethodException e) {
-            e.printStackTrace();
-        } catch (InvocationTargetException e) {
-            e.printStackTrace();
+        } catch (Exception e) {
+            // intentionally ignored
         }
+
     }
 
     @Override

diff --git a/Src/java/engine/src/main/java/org/opencds/cqf/cql/engine/exception/CqlExceptionHandler.java b/Src/java/engine/src/main/java/org/opencds/cqf/cql/engine/exception/CqlExceptionHandler.java
diff --git a/Src/java/model/src/main/java/org/hl7/cql/model/SystemModelInfoProvider.java b/Src/java/model/src/main/java/org/hl7/cql/model/SystemModelInfoProvider.java
@@ -26,9 +26,7 @@ public ModelInfo load(ModelIdentifier modelIdentifier) {
             try {
                 return ModelInfoReaderFactory.getReader("application/xml").read(SystemModelInfoProvider.class.getResourceAsStream("/org/hl7/elm/r1/system-modelinfo.xml"));
             } catch (IOException e) {
-                e.printStackTrace();
                 // Do not throw, allow other providers to resolve
-                //    throw new IllegalArgumentException(String.format("Unknown version %s of the System model.", localVersion));
             }
         }
 

diff --git a/Src/java/qdm/src/main/java/org/cqframework/cql/cql2elm/qdm/QdmModelInfoProvider.java b/Src/java/qdm/src/main/java/org/cqframework/cql/cql2elm/qdm/QdmModelInfoProvider.java
@@ -56,9 +56,7 @@ public ModelInfo load(ModelIdentifier modelIdentifier) {
                         return ModelInfoReaderFactory.getReader("application/xml").read(QdmModelInfoProvider.class.getResourceAsStream("/gov/healthit/qdm/qdm-modelinfo-5.6.xml"));
                 }
             } catch (IOException e) {
-                e.printStackTrace();
-            // Do not throw, allow other providers to resolve
-            //    throw new IllegalArgumentException(String.format("Unknown version %s of the QDM model.", localVersion));
+                // Do not throw, allow other providers to resolve
             }
         }
 

diff --git a/Src/java/quick/src/main/java/org/cqframework/cql/cql2elm/quick/FhirModelInfoProvider.java b/Src/java/quick/src/main/java/org/cqframework/cql/cql2elm/quick/FhirModelInfoProvider.java
@@ -66,9 +66,7 @@ public ModelInfo load(ModelIdentifier modelIdentifier) {
                     //    throw new IllegalArgumentException(String.format("Unknown version %s of the FHIR model.", localVersion));
                 }
             } catch (IOException e) {
-                e.printStackTrace();
                 // Do not throw, allow other providers to resolve
-                //    throw new IllegalArgumentException(String.format("Unknown version %s of the Fhir model.", localVersion));
             }
         }
 

diff --git a/Src/java/quick/src/main/java/org/cqframework/cql/cql2elm/quick/QICoreModelInfoProvider.java b/Src/java/quick/src/main/java/org/cqframework/cql/cql2elm/quick/QICoreModelInfoProvider.java
@@ -40,9 +40,7 @@ public ModelInfo load(ModelIdentifier modelIdentifier) {
                         return ModelInfoReaderFactory.getReader("application/xml").read(QICoreModelInfoProvider.class.getResourceAsStream("/org/hl7/fhir/qicore-modelinfo-5.0.0.xml"));
                 }
             } catch (IOException e) {
-                e.printStackTrace();
                 // Do not throw, allow other providers to resolve
-                //    throw new IllegalArgumentException(String.format("Unknown version %s of the QI model.", localVersion));
             }
         }
 

diff --git a/...ava/quick/src/main/java/org/cqframework/cql/cql2elm/quick/QuickFhirModelInfoProvider.java b/...ava/quick/src/main/java/org/cqframework/cql/cql2elm/quick/QuickFhirModelInfoProvider.java
@@ -37,9 +37,7 @@ public ModelInfo load(ModelIdentifier modelIdentifier) {
                         return ModelInfoReaderFactory.getReader("application/xml").read(QuickFhirModelInfoProvider.class.getResourceAsStream("/org/hl7/fhir/quickfhir-modelinfo-3.0.1.xml"));
                 }
             } catch (IOException e) {
-                e.printStackTrace();
                 // Do not throw, allow other providers to resolve
-                //    throw new IllegalArgumentException(String.format("Unknown version %s of the QUICKFHIR model.", localVersion));
             }
 
         }

diff --git a/Src/java/quick/src/main/java/org/cqframework/cql/cql2elm/quick/QuickModelInfoProvider.java b/Src/java/quick/src/main/java/org/cqframework/cql/cql2elm/quick/QuickModelInfoProvider.java
@@ -27,7 +27,7 @@ private boolean isQuickModelIdentifier(ModelIdentifier modelIdentifier) {
     public ModelInfo load(ModelIdentifier modelIdentifier) {
         if (isQuickModelIdentifier(modelIdentifier)) {
             String localVersion = modelIdentifier.getVersion() == null ? "" : modelIdentifier.getVersion();
-            
+
             try {
                 switch (localVersion) {
                     case "3.3.0":
@@ -38,11 +38,9 @@ public ModelInfo load(ModelIdentifier modelIdentifier) {
                         return ModelInfoReaderFactory.getReader("application/xml").read(QuickModelInfoProvider.class.getResourceAsStream("/org/hl7/fhir/quick-modelinfo.xml"));
                 }
             } catch (IOException e) {
-                e.printStackTrace();
                 // Do not throw, allow other providers to resolve
-                //    throw new IllegalArgumentException(String.format("Unknown version %s of the Fhir model.", localVersion));
             }
-            
+
         }
 
         return null;

diff --git a/Src/java/quick/src/main/java/org/cqframework/cql/cql2elm/quick/UsCoreModelInfoProvider.java b/Src/java/quick/src/main/java/org/cqframework/cql/cql2elm/quick/UsCoreModelInfoProvider.java
@@ -37,11 +37,9 @@ public ModelInfo load(ModelIdentifier modelIdentifier) {
                         return ModelInfoReaderFactory.getReader("application/xml").read(QuickModelInfoProvider.class.getResourceAsStream("/org/hl7/fhir/uscore-modelinfo-3.1.1.xml"));
                 }
             } catch (IOException e) {
-                e.printStackTrace();
                 // Do not throw, allow other providers to resolve
-                //    throw new IllegalArgumentException(String.format("Unknown version %s of the Fhir model.", localVersion));
             }
-            
+
         }
 
         return null;