Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for gaps in the ELM visitor #1308

Merged
merged 12 commits into from
Dec 22, 2023
Merged

Fixes for gaps in the ELM visitor #1308

merged 12 commits into from
Dec 22, 2023

Conversation

JPercival
Copy link
Contributor

  • Added architecture tests to ensure ElmVisitor followed the expected conventions
  • Added random ELM graph generation to ensure all nodes are visited
  • Renamed ElmBaseVisitor -> BaseElmVisitor to match conventions for abstract classes
  • Removed code that was pass through to super class
  • Fixed traversal bugs to ensure operands and arguments are visited correctly

Copy link

Formatting check succeeded!

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (cf7c30a) 62.64% compared to head (5fd11a7) 62.70%.

Files Patch % Lines
...k/cql/elm/requirements/ElmRequirementsVisitor.java 84.90% 4 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1308      +/-   ##
============================================
+ Coverage     62.64%   62.70%   +0.05%     
+ Complexity     6158     6079      -79     
============================================
  Files           466      466              
  Lines         25424    25308     -116     
  Branches       4703     4711       +8     
============================================
- Hits          15928    15869      -59     
+ Misses         7348     7288      -60     
- Partials       2148     2151       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JPercival JPercival merged commit cc869ca into master Dec 22, 2023
4 checks passed
@JPercival JPercival deleted the bug-elm-visitor branch December 22, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants