-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for gaps in the ELM visitor #1308
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JPercival
commented
Dec 22, 2023
- Added architecture tests to ensure ElmVisitor followed the expected conventions
- Added random ELM graph generation to ensure all nodes are visited
- Renamed ElmBaseVisitor -> BaseElmVisitor to match conventions for abstract classes
- Removed code that was pass through to super class
- Fixed traversal bugs to ensure operands and arguments are visited correctly
…nce and only once
Formatting check succeeded! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1308 +/- ##
============================================
+ Coverage 62.64% 62.70% +0.05%
+ Complexity 6158 6079 -79
============================================
Files 466 466
Lines 25424 25308 -116
Branches 4703 4711 +8
============================================
- Hits 15928 15869 -59
+ Misses 7348 7288 -60
- Partials 2148 2151 +3 ☔ View full report in Codecov by Sentry. |
Capt-Mac
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.