-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
engine-fhir tests improvements #1369
Merged
JPercival
merged 12 commits into
cqframework:master
from
antvaset:engine-fhir-tests-improvements-2
Jun 21, 2024
Merged
engine-fhir tests improvements #1369
JPercival
merged 12 commits into
cqframework:master
from
antvaset:engine-fhir-tests-improvements-2
Jun 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1369 +/- ##
============================================
- Coverage 62.26% 62.26% -0.01%
- Complexity 6951 6953 +2
============================================
Files 492 492
Lines 27727 27731 +4
Branches 5506 5508 +2
============================================
+ Hits 17265 17266 +1
- Misses 8198 8200 +2
- Partials 2264 2265 +1 ☔ View full report in Codecov by Sentry. |
brynrhodes
approved these changes
Jun 19, 2024
JPercival
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few small changes:
null
when base is 1. The spec saysIf the result of the operation cannot be represented, the result is null.
(source). Added new test case forlog_1(2)
in addition tolog_1(1)
.(-10^28^+1)/10^8^..(10^28^-1)/10^8^
, i.e.-99999999999999999999.99999999..99999999999999999999.99999999
(20 nines before the decimal point and 8 nines after the decimal point).10L div 3L
now returns3L
as expected.null
if the element argument isnull
as per the spec.Includes_NegInfBegIncludesDateIvl
test in theCqlTestSuite
library which was failing in NZ timezone: When the lower boundary of DateTime-typed Interval isnull
, it is set tominimum DateTime
which strictly speaking returnsDateTime(1, 1, 1, 0, 0, 0, 0, 0)
and notDateTime(1, 1, 1, 0, 0, 0, 0)
.