Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine-fhir tests improvements #1369

Merged

Conversation

antvaset
Copy link
Contributor

@antvaset antvaset commented Jun 17, 2024

A few small changes:

  • Fixed Log operator evaluation: Log returns null when base is 1. The spec says If the result of the operation cannot be represented, the result is null. (source). Added new test case for log_1(2) in addition to log_1(1).
  • Fixed the ranges for the Decimal type: As per the spec, decimal values are in range (-10^28^+1)/10^8^..(10^28^-1)/10^8^, i.e. -99999999999999999999.99999999..99999999999999999999.99999999 (20 nines before the decimal point and 8 nines after the decimal point).
  • Added support for Long types in truncated division: 10L div 3L now returns 3L as expected.
  • Fixed IndexOf operator evaluation: IndexOf returns null if the element argument is null as per the spec.
  • Fixed the Includes_NegInfBegIncludesDateIvl test in the CqlTestSuite library which was failing in NZ timezone: When the lower boundary of DateTime-typed Interval is null, it is set to minimum DateTime which strictly speaking returns DateTime(1, 1, 1, 0, 0, 0, 0, 0) and not DateTime(1, 1, 1, 0, 0, 0, 0).

@antvaset antvaset marked this pull request as draft June 17, 2024 20:53
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 62.26%. Comparing base (e00c396) to head (74bf237).
Report is 1 commits behind head on master.

Files Patch % Lines
...engine/elm/executing/TruncatedDivideEvaluator.java 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1369      +/-   ##
============================================
- Coverage     62.26%   62.26%   -0.01%     
- Complexity     6951     6953       +2     
============================================
  Files           492      492              
  Lines         27727    27731       +4     
  Branches       5506     5508       +2     
============================================
+ Hits          17265    17266       +1     
- Misses         8198     8200       +2     
- Partials       2264     2265       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antvaset antvaset marked this pull request as ready for review June 18, 2024 08:35
@JPercival JPercival merged commit 508bfad into cqframework:master Jun 21, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants