Reporting coverage across subprojects

[antvaset]

Currently, the JaCoCo test reports which are run separately for the engine-fhir, engine, cql-to-elm subprojects only include the classes from the default source sets. This means that e.g. the coverage of cql-to-elm classes is not reported when running engine-fhir tests. Concrete example: resolveMethod in the cql-to-elm subproject has low coverage (link) even though there are many tests for FHIRPath methods inside engine-fhir (link).

Here I'm trying to get code coverage to be reported across subprojects and see if codecov can aggregate the reports which seems to be the case. See coverage for resolveMethod after changing jacocoTestReport config (link) and overall change in coverage for the affected classes (link).

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.65%. Comparing base (e00c396) to head (f76f939).
Report is 3 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #1374      +/-   ##
============================================
+ Coverage     62.26%   63.65%   +1.38%     
+ Complexity     6951     2666    -4285     
============================================
  Files           492      492              
  Lines         27727    27731       +4     
  Branches       5506     5508       +2     
============================================
+ Hits          17265    17652     +387     
+ Misses         8198     7830     -368     
+ Partials       2264     2249      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[JPercival]

I agree with this change since it better reflects our actual test coverage. I'll just note that it suggests that our test structure is suboptimal, since we need to includes results across several projects to get the real result.