Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporting coverage across subprojects #1374

Merged
merged 5 commits into from
Jul 3, 2024

Conversation

antvaset
Copy link
Contributor

@antvaset antvaset commented Jun 28, 2024

Currently, the JaCoCo test reports which are run separately for the engine-fhir, engine, cql-to-elm subprojects only include the classes from the default source sets. This means that e.g. the coverage of cql-to-elm classes is not reported when running engine-fhir tests. Concrete example: resolveMethod in the cql-to-elm subproject has low coverage (link) even though there are many tests for FHIRPath methods inside engine-fhir (link).

Here I'm trying to get code coverage to be reported across subprojects and see if codecov can aggregate the reports which seems to be the case. See coverage for resolveMethod after changing jacocoTestReport config (link) and overall change in coverage for the affected classes (link).

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.65%. Comparing base (e00c396) to head (f76f939).
Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1374      +/-   ##
============================================
+ Coverage     62.26%   63.65%   +1.38%     
+ Complexity     6951     2666    -4285     
============================================
  Files           492      492              
  Lines         27727    27731       +4     
  Branches       5506     5508       +2     
============================================
+ Hits          17265    17652     +387     
+ Misses         8198     7830     -368     
+ Partials       2264     2249      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@JPercival JPercival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this change since it better reflects our actual test coverage. I'll just note that it suggests that our test structure is suboptimal, since we need to includes results across several projects to get the real result.

@JPercival JPercival merged commit 82b3584 into cqframework:master Jul 3, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants