Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Message operator tests #1402

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

antvaset
Copy link
Contributor

Merged tests from engine/.../CqlErrorsAndMessagingOperatorsTest.cql into CqlErrorsAndMessagingOperatorsTest.xml.

Keeping the CQL library with the following define's:

  1. These are used in Java tests to test the engine messages (logs) produced by the Message operator with the 'Message', 'Warning', and 'Trace' severities:
TestMessageInfo
TestMessageWarn
TestMessageTrace
  1. These are used in Java tests to test that the runtime throws when the severity is 'Error' (I also adjusted the Java tests for these define's so that they fail if the engine does not throw):
TestMessageError
TestErrorWithNullSource
TestErrorWithNullCode
TestErrorWithNullMessage

Note that the TestErrorWithNullCondition is not supposed to throw but the old test was passing because it didn't fail when the engine didn't throw:

define TestErrorWithNullCondition:
  Message(1, null, '1', 'Error', 'This is a message')

At the moment this is a draft and depends on #1401. Once I'm sure we can have Message calls with nulls without casts, I'll raise a corresponding PR to update cql-tests.

Copy link

Formatting check succeeded!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant