Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged tests from
engine/.../CqlErrorsAndMessagingOperatorsTest.cql
intoCqlErrorsAndMessagingOperatorsTest.xml
.Keeping the CQL library with the following define's:
Message
operator with the'Message'
,'Warning'
, and'Trace'
severities:'Error'
(I also adjusted the Java tests for these define's so that they fail if the engine does not throw):Note that the
TestErrorWithNullCondition
is not supposed to throw but the old test was passing because it didn't fail when the engine didn't throw:At the moment this is a draft and depends on #1401. Once I'm sure we can have
Message
calls withnull
s without casts, I'll raise a corresponding PR to update cql-tests.