Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for converting CQL Tuples to FHIR Parameters #1422

Merged
merged 10 commits into from
Oct 10, 2024

Conversation

JPercival
Copy link
Contributor

  • Add support for converting CQL Tuples to FHIR Parameters
  • Tests for same

Copy link

github-actions bot commented Oct 7, 2024

Formatting check succeeded!

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 93.18182% with 12 lines in your changes missing coverage. Please review.

Project coverage is 64.38%. Comparing base (4e3be26) to head (8f790d3).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../engine/fhir/converter/Dstu2FhirTypeConverter.java 93.18% 2 Missing and 1 partial ⚠️
.../engine/fhir/converter/Dstu3FhirTypeConverter.java 93.18% 2 Missing and 1 partial ⚠️
...cql/engine/fhir/converter/R4FhirTypeConverter.java 93.18% 2 Missing and 1 partial ⚠️
...cql/engine/fhir/converter/R5FhirTypeConverter.java 93.18% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1422      +/-   ##
============================================
+ Coverage     64.20%   64.38%   +0.18%     
- Complexity     1867     1920      +53     
============================================
  Files           494      494              
  Lines         27848    28020     +172     
  Branches       5531     5559      +28     
============================================
+ Hits          17880    18041     +161     
- Misses         7731     7738       +7     
- Partials       2237     2241       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@brynrhodes brynrhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nested tuples weren't being handled correctly, and in fixing that I actually found a gap in empty tuple representation. I've submitted JIRA trackers to the extensions library and CQL IG to address that gap, and pre-adopted the solution in my updates to this PR.

@JPercival JPercival enabled auto-merge (squash) October 10, 2024 21:51
Copy link

sonarcloud bot commented Oct 10, 2024

@barhodes barhodes self-requested a review October 10, 2024 22:13
@JPercival JPercival merged commit b50ea52 into master Oct 10, 2024
6 checks passed
@JPercival JPercival deleted the feature-tuples branch October 10, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants