Merge pull request #364 from craftcms/bugfix/359-source-editing-group…

…s-can-be-null `sourceEditingGroups` can be null too
craftcms · Feb 18, 2025 · ceee4a7 · ceee4a7
2 parents 4af3244 + 6fa6292
commit ceee4a7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Release Notes for CKEditor for Craft CMS
 
+## Unreleased
+
+- Fixed an error that occurred if the “Who should see the ‘Source’ button?” field setting was totally blank. ([#359](https://github.com/craftcms/ckeditor/issues/359))
+
 ## 3.11.0 - 2025-01-23
 
 - CKEditor fields no longer have extra bottom padding, and the CKEditor logo is now displayed over the bottom border. ([#252](https://github.com/craftcms/ckeditor/pull/252))

diff --git a/src/Field.php b/src/Field.php
@@ -585,6 +585,10 @@ private function isSourceEditingAllowed(User $user): bool
             return true;
         }
 
+        if ($this->sourceEditingGroups === null) {
+            return false;
+        }
+
         $sourceEditingGroups = array_flip($this->sourceEditingGroups);
 
         if ($user->admin && isset($sourceEditingGroups['__ADMINS__'])) {