-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/update installation method #363
Draft
brianjhanson
wants to merge
40
commits into
5.x
Choose a base branch
from
feature/update-installation-method
base: 5.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-installation-method
95cadf1
to
347af19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates CKEditor to use the new installation methods. The big change between old and new is that the new no longer supports DDLs and leans all in to JavaScript imports and import maps.
Updating Plugins
For the most part, plugin authors should follow the instructions in the migrating custom plugins documentation from CKEditor.
On the Craft side, the updates aren't too involved.
BaseCkeditorPackageAsset
must now include a$namespace
property that will be the module for the import statement generated. It can technically be almost anything, but using a@{author}/ckeditor5-{handle}
format is recommended.Plugin::registerCkeditorPackage()
call so we can properly format theimport
statement for your plugin.First Party plugins
If all you want to do is add a first party plugin (like
ImageResize
we've added aCkeditorConfig::registerFirstPartyPackage()
method you can call from your plugin or module'sinit
method.Extra plugins will be included into the
ckeditor5
JavaScript import statement.Browser Support
Because the new installation methods rely on
importmaps
this plugin includes a shim for older browsers that may not support them.