Fixed #3544 catalog pricing product conditions potentially not applying

craftcms · Sep 5, 2024 · 8c9ebd8 · 8c9ebd8
1 parent c06f90a
commit 8c9ebd8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Release Notes for Craft Commerce
 
+## Unreleased
+
+- Fixed a bug where catalog pricing rules could ignore product conditions. ([#3544](https://github.com/craftcms/commerce/issues/3544))
+
 ## 5.1.0 - 2024-09-04
 
 ### Store Management

diff --git a/src/models/CatalogPricingRule.php b/src/models/CatalogPricingRule.php
@@ -259,7 +259,7 @@ public function getPurchasableIds(): ?array
 
             $this->_purchasableIds = $productVariantIds;
 
-            $variantIds = null;
+            $variantIds = $productVariantIds;
             if (!empty($this->getVariantCondition()->getConditionRules())) {
                 $variantQuery = Variant::find();
                 /** @var CatalogPricingRuleVariantCondition $variantCondition */