Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move recalculation inside of cart controller #3878

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Move recalculation inside of cart controller #3878

merged 3 commits into from
Feb 5, 2025

Conversation

lukeholder
Copy link
Member

@lukeholder lukeholder commented Feb 3, 2025 •
edited
Loading

Description

This is a potential fix for #3873

@lukeholder lukeholder changed the base branch from 5.x to 4.x February 3, 2025 05:16
@lukeholder lukeholder self-assigned this Feb 3, 2025
@lukeholder lukeholder mentioned this pull request Feb 3, 2025
Open
@lukeholder lukeholder marked this pull request as ready for review February 4, 2025 07:19
@lukeholder lukeholder requested a review from a team as a code owner February 4, 2025 07:19
nfourtythree
nfourtythree approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@nfourtythree nfourtythree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukeholder lukeholder merged commit 2088456 into 4.x Feb 5, 2025
15 checks passed
@lukeholder lukeholder deleted the bugfix/3873 branch February 5, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfourtythree nfourtythree nfourtythree approved these changes

Assignees

@lukeholder lukeholder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukeholder @nfourtythree