Fixed bug where not all data for new line item was passed to the resolve line item process.

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## Unreleased
 
+- Fixed a bug where new line items did not expose their submitted quantity to the `craft\commerce\services\LineItems::EVENT_POPULATE_LINE_ITEM` event. ([#3883](https://github.com/craftcms/commerce/issues/3883))
 - Fixed a bug where soft-deleted variants were not being restored when the product was restored. ([#3815](https://github.com/craftcms/commerce/issues/3815))
 - Fixed a bug where inventory movements did not update the purchasable’s per-store cached stock total.
 - Fixed a bug where transfers that contained deleted inventory items could not be updated.

src/controllers/CartController.php

@@ -164,12 +164,15 @@ public function actionUpdateCart(): ?Response
             $options = $this->request->getParam('options', []); // TODO Commerce 4 should only support key value only #COM-55
             $qty = (int)$this->request->getParam('qty', 1);
 
+            $params = compact('qty', 'note', 'purchasableId', 'options');
+
             if ($qty > 0) {
                 // We only want a new line item if they cleared the cart
                 if ($clearLineItems) {
-                    $lineItem = Plugin::getInstance()->getLineItems()->create($this->_cart, compact('purchasableId', 'options'));
+                    $lineItem = Plugin::getInstance()->getLineItems()->create($this->_cart, params: $params);
                 } else {
-                    $lineItem = Plugin::getInstance()->getLineItems()->resolveLineItem($this->_cart, $purchasableId, $options);
+                    // we are passing everything into params but need to pass purchasableId and options for now until we refactor
+                    $lineItem = Plugin::getInstance()->getLineItems()->resolveLineItem($this->_cart, $params['purchasableId'], $params['options'], params: $params);
                 }
 
                 // New line items already have a qty of one.
@@ -216,15 +219,18 @@ public function actionUpdateCart(): ?Response
 
                 // Ignore zero value qty for multi-add forms https://github.com/craftcms/commerce/issues/330#issuecomment-384533139
                 if ($purchasable['qty'] > 0) {
+                    $params = [
+                        'purchasableId' => $purchasable['id'],
+                        'options' => $purchasable['options'],
+                        'note' => $purchasable['note'],
+                        'qty' => $purchasable['qty'],
+                    ];
 
                     // We only want a new line item if they cleared the cart
                     if ($clearLineItems) {
-                        $lineItem = Plugin::getInstance()->getLineItems()->create($this->_cart, [
-                            'purchasableId' => $purchasable['id'],
-                            'options' => $purchasable['options'],
-                        ]);
+                        $lineItem = Plugin::getInstance()->getLineItems()->create($this->_cart, params: $params);
                     } else {
-                        $lineItem = Plugin::getInstance()->getLineItems()->resolveLineItem($this->_cart, $purchasable['id'], $purchasable['options']);
+                        $lineItem = Plugin::getInstance()->getLineItems()->resolveLineItem($this->_cart, $params['purchasableId'], $params['options'], $params);
                     }
 
                     // New line items already have a qty of one.

src/services/LineItems.php

@@ -176,7 +176,7 @@ public function getAllLineItemsByOrderId(int $orderId): array
      * @return LineItem
      * @throws \Exception
      */
-    public function resolveLineItem(Order $order, int $purchasableId, array $options = []): LineItem
+    public function resolveLineItem(Order $order, int $purchasableId, array $options = [], array $params = []): LineItem
     {
         $signature = LineItemHelper::generateOptionsSignature($options);
 
@@ -191,7 +191,14 @@ public function resolveLineItem(Order $order, int $purchasableId, array $options
         if ($result) {
             $lineItem = new LineItem($result);
         } else {
-            $lineItem = $this->create($order, compact('purchasableId', 'options'));
+            $params = array_merge([
+                'qty' => 1,
+                'options' => $options,
+                'note' => '',
+                'purchasableId' => $purchasableId,
+            ], $params);
+
+            $lineItem = $this->create($order, $params);
         }
 
         return $lineItem;