Skip to content

Add command SetVisibilityTimeout #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 28, 2025

Conversation

dbenders
Copy link
Contributor

@dbenders dbenders commented Apr 3, 2025

No description provided.

@craigpastro craigpastro changed the title Add command SetVisivilityTimeout Add command SetVisibilityTimeout Apr 4, 2025
@craigpastro
Copy link
Owner

craigpastro commented Apr 4, 2025

Hey @dbenders! This PR LGTM! I just pushed a fix for the TestQueue error. If you rebase then we can merge this. Thanks for your contribution!

Edit: I'll rebase.
Edit2: One small comment.

Copy link

codecov bot commented Apr 28, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 89.61%. Comparing base (0bbf6f7) to head (7fbcde3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pgmq.go 59.09% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
- Coverage   90.43%   89.61%   -0.83%     
==========================================
  Files           2        2              
  Lines         523      568      +45     
==========================================
+ Hits          473      509      +36     
- Misses         33       39       +6     
- Partials       17       20       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@craigpastro
Copy link
Owner

Thanks for your contribution ❤️

@craigpastro craigpastro merged commit 3436624 into craigpastro:main Apr 28, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants