-
Notifications
You must be signed in to change notification settings - Fork 1
Move "Getting started" to the root of the TOC #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis PR reorganizes documentation: cleans front matter in docs/home/index.md, replaces the verbose docs/index.md homepage with a minimal top-level toctree, adds a new handbook landing page at docs/handbook/index.md, and updates the docs theme dependency in docs/requirements.txt. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10–15 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (1)
docs/guides/index.md (1)
305-305
: Drop the unused link reference.The
[Overview of CrateDB integration tutorials]
definition is never referenced, triggering MD053. Please either use it or remove the definition.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
docs/guides/index.md
(1 hunks)docs/home/index.md
(0 hunks)docs/index.md
(1 hunks)docs/requirements.txt
(1 hunks)
💤 Files with no reviewable changes (1)
- docs/home/index.md
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
docs/guides/index.md
131-131: Images should have alternate text (alt text)
(MD045, no-alt-text)
305-305: Link and image reference definitions should be needed
Unused link or image reference definition: "overview of cratedb integration tutorials"
(MD053, link-image-reference-definitions)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting your hack to the docs theme. I am not yet convinced if the quirkyness satisfies the outcome, but let's try on behalf of a preview release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to relocate this file, or can we do it differently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't see any other way. It also seems logical to me as this becomes a submenu now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood, thanks.
@amotl Preview now available: See https://cratedb-guide--348.org.readthedocs.build/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to relocate the previous
docs/index
page here, as this becomes a submenu now, and the "root" page will no longer exist.
Can you rename this to handbook
, to accompany the other patch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the patch includes mostly refactoring, let's give it a try. Thanks again for going down the rabbithole on attempting to hack our Sphinx setup. Please understand I can't promise anything if this is suitable for the long term. Yet, let's integrate your patch swiftly now if it gets your job done.
ProblemThis happens on the first hit to request a newly uploaded package when pulling it from PyPI, as if that action would hit an empty cache slot that does not automatically populate from its source in a blocking way.
SolutionJust hit "Rebuild" or "Re-run" once. -- https://app.readthedocs.org/projects/cratedb-guide/builds/29840753/ OutlookSubsequent package pulls will no longer fail, as caches are correctly populated now. |
Summary of the changes / Why this is an improvement
Move Getting Started to the root of the TOC after the first Overview page.
This requires coordinated released of the theme: crate/crate-docs-theme#627, assuming this is released as 0.42.0.
Preview
See https://cratedb-guide--348.org.readthedocs.build/
The TOC looks like this at first level:

Checklist