-
Notifications
You must be signed in to change notification settings - Fork 1
CrateDB 3.x: Documentation for 3.3 turned off, so refer to sources instead. Also tune down other content. #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis PR updates documentation links and guidance: it rehomes several clustering-related anchors into a new CrateDB 3.x section, repoints multiple cross-references from cratedb.com to GitHub blob URLs, adjusts Kubernetes recovery/scaling notes, and removes the CrateDB 3.3 URL from Sphinx's linkcheck_ignore. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (5)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
🧰 Additional context used🧠 Learnings (1)📓 Common learnings
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx! But maybe consider removing any reference to 3.x now that we have moved on?
It was actually meant to be a reference for people who are still running CrateDB 3.x. Don't you think it is a good idea? Sure enough, in order to simplify presentation, we could de-inline all docs relevant for CrateDB 3.x, but bundle them into relevant "Appendix" sections instead. wdyt? |
No strong opinion, just an idea, since we're now 3 major versions ahead of that. |
c4e0219 further tunes down content about CrateDB 3.x, without removing it just yet. You can review the changes here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx!
About
We turned off CrateDB 3.3 docs recently.
Preview