-
Notifications
You must be signed in to change notification settings - Fork 1
Start/Index: Refactor "Going further" to "Learn more" on index page #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughEdits restructure the start documentation (replace card layout with sd-table rows, add a "Learn more" section, update toctree), remove the standalone "Going further" page, and update the performance index heading and add two new performance cards. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
876e6ad
to
384df94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking up that comment!
There are quite a few things I would like to change here, so let me get back on that.
I also would like to change a lot of things everywhere. This patch was just meant to quickly relocate the content so others can further curate it at their disposal. Maybe your ideas fit well into a subsequent patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually appreciate the speedyness! But I would keep current state than merging this as is. I have more concrete feedback, please allow me to get time for that.
It is really just a refactoring patch that barely changes any content. Maybe other feedback beyond that would be better suited as a dedicated ticket? You can easily add your feedback any time to improve particular pages per "Suggest improvement" workflow. ![]() -- https://cratedb.com/docs/guide/start/ |
About
Preview
References