CrateDB: Subtract features from PostgreSQL adapter to make CrateDB work #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The server log still includes many errors and tracebacks, but basic operations like syncing of system tables from the `sys` schema, and exploring data works again, after it stopped working with Metabase v0.48.4.
This was referenced Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
The server log still includes many errors and tracebacks, but basic operations like syncing of system tables from the
sysschema, and exploring data works again, after it stopped working with Metabase v0.48.4.Backlog
The code probably needs to be wrapped up into a dedicated data source adapter for CrateDB, deriving from the one for PostgreSQL, possibly how Redshift 1 and other drivers are also doing it.
Footnotes
https://github.com/metabase/metabase/blob/v1.52.1.1/modules/drivers/redshift/src/metabase/driver/redshift.clj ↩