Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows build GitHub Action #420

Merged
merged 13 commits into from
May 6, 2024
Merged

Conversation

simonhamp
Copy link
Contributor

@simonhamp simonhamp commented Apr 24, 2024

What does this PR do?

Adds a GitHub Action for building on Windows.

This is a first pass that builds an executable, but it's still WIP - please leave this PR open as I will be pushing to the original branch as we work through fixing it.

Current known issues:

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If it's a extension or dependency update, make sure adding related extensions in src/global/test-extensions.php.
  • If you changed the behavior of static-php-cli, add docs in static-php/static-php-cli-docs .
  • If you updated config/xxxx.json content, run bin/spc dev:sort-config xxx.

@simonhamp simonhamp marked this pull request as draft April 24, 2024 18:18
@crazywhalecc crazywhalecc added enhancement New feature or request kind/workflow Issues related to workflow or environment os/windows Things only for Windows labels Apr 25, 2024
@simonhamp simonhamp mentioned this pull request Apr 26, 2024
3 tasks
@simonhamp simonhamp changed the title WIP: Windows build GitHub Action Windows build GitHub Action May 1, 2024
@simonhamp simonhamp marked this pull request as ready for review May 1, 2024 18:28
@simonhamp
Copy link
Contributor Author

I'm not sure we need to worry too much about SmartScreen for now... certainly not before this action can be used. It works well and the builds seem fairly portable

@simonhamp
Copy link
Contributor Author

The test failures here seem to be due to hitting GitHub's rate limits

@crazywhalecc
Copy link
Owner

It seems that my GITHUB_TOKEN has expired, I will update it.

@crazywhalecc crazywhalecc merged commit 30af182 into crazywhalecc:main May 6, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request kind/workflow Issues related to workflow or environment os/windows Things only for Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants