-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows build GitHub Action #420
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazywhalecc
added
enhancement
New feature or request
kind/workflow
Issues related to workflow or environment
os/windows
Things only for Windows
labels
Apr 25, 2024
simonhamp
changed the title
WIP: Windows build GitHub Action
Windows build GitHub Action
May 1, 2024
I'm not sure we need to worry too much about SmartScreen for now... certainly not before this action can be used. It works well and the builds seem fairly portable |
The test failures here seem to be due to hitting GitHub's rate limits |
It seems that my GITHUB_TOKEN has expired, I will update it. |
crazywhalecc
requested changes
May 6, 2024
crazywhalecc
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
kind/workflow
Issues related to workflow or environment
os/windows
Things only for Windows
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a GitHub Action for building on Windows.
This is a first pass that builds an executable, but it's still WIP - please leave this PR open as I will be pushing to the original branch as we work through fixing it.
Current known issues:
It currently seems to only build PHP8.2 - I haven't started to dig into whyThis was because my cache key logic was broken. It works nowChecklist before merging
src/global/test-extensions.php
.config/xxxx.json
content, runbin/spc dev:sort-config xxx
.