-
-
Notifications
You must be signed in to change notification settings - Fork 336
Export php binary external debug symbol files #953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I think we should refactor the debug copy out to its own function and put it in buildroot/debug. And of course also do it for shared libs. |
I'm not quite sure if it's necessary to generate both of them simultaneously. But I think we could just keep the unstripped version in |
|
No, it should behave the same way for all binaries. function extractDebugInfo($path) {
$file = filename($path);
$dir = basename($path);
shell()->cd($dir)
->exec("objcopy ---only-debug-info $file $file.debug");
...
mv($file . '.debug', BUILD_DEBUG_PATH);
}And then call that for every binary in BIN/LIB/MODULES paths. |
It looks impossible for current situation, we have no defines for the executables that should be stripped. But we could separate functions |
henderkes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, but we still need to call extractDebugInfo() on all *.so files in BUILD_LIB_PATH and BUILD_MODULES_PATH.
|
Looks good now, I'll spin it up tonight. |
What does this PR do?
Closes #949
Checklist before merging
*.phpor*.json, run them locally to ensure your changes are valid:composer cs-fixcomposer analysecomposer testbin/spc dev:sort-configsrc/globals/test-extensions.php.extension testortest extensionsto trigger full test suite.