fix adding defaults and access to new methods and button_type

django_object_actions/templates/django_object_actions/action_trigger.html

@@ -1,14 +1,6 @@
 {% load add_preserved_filters from admin_urls %}
 
-{% if tool.button_type == 'a' %}
-  <a href="{% add_preserved_filters action_url %}"
-    title="{{ tool.standard_attrs.title }}"
-    {% for k, v in tool.custom_attrs.items %}
-      {{ k }}="{{ v }}"
-    {% endfor %}
-    class="{{ tool.standard_attrs.class }}"
-  >{{ tool.label|capfirst }}</a>
-{% elif tool.button_type == 'form' %}
+{% if tool.button_type == 'form' %}
   <form method="post" action="{% add_preserved_filters action_url %}">
     {% csrf_token %}
     <a href="#" onclick="this.parentNode.submit(); return false;"
@@ -19,4 +11,12 @@
       class="{{ tool.standard_attrs.class }}"
     >{{ tool.label|capfirst }}</a>
   </form>
+{% else %}
+  <a href="{% add_preserved_filters action_url %}"
+    title="{{ tool.standard_attrs.title }}"
+    {% for k, v in tool.custom_attrs.items %}
+      {{ k }}="{{ v }}"
+    {% endfor %}
+    class="{{ tool.standard_attrs.class }}"
+  >{{ tool.label|capfirst }}</a>
 {% endif %}

django_object_actions/utils.py

@@ -2,6 +2,7 @@
 from itertools import chain
 
 from django.contrib import messages
+from django.contrib.admin import ModelAdmin
 from django.contrib.admin.utils import unquote
 from django.db.models.query import QuerySet
 from django.http import Http404, HttpResponseRedirect
@@ -159,7 +160,7 @@ def _get_tool_dict(self, tool_name):
             label=getattr(tool, "label", tool_name.replace("_", " ").capitalize()),
             standard_attrs=standard_attrs,
             custom_attrs=custom_attrs,
-            button_type=tool.button_type,
+            button_type=getattr(tool, "button_type", "a"),
         )
 
     def _get_button_attrs(self, tool):
@@ -218,6 +219,7 @@ class BaseActionView(View):
     model = None
     actions = None
     current_app = None
+    methods = ("GET", "POST")
 
     @property
     def view_args(self):
@@ -249,7 +251,7 @@ def dispatch(self, request, tool, **kwargs):
         except KeyError:
             raise Http404("Action does not exist")
 
-        if request.method not in view.methods:
+        if request.method not in self.methods:
             return HttpResponseNotAllowed(view.methods)
 
         ret = view(request, *self.view_args)