Skip to content

Commit

Permalink
Fix issue with social buttons. (USRSE#1205)
Browse files Browse the repository at this point in the history
The `site.url` variable needs to be the site domain.
The absence of a value causes URLs using `site.url` to not
contain this, which then prevents social sites from linking
to the site.

This change fixes the `site.url` variable and maintains
the circleci build behavior to maintain preview of assets.

Closes USRSE#1201
  • Loading branch information
aholmes authored Jun 29, 2023
1 parent 6b36af7 commit 41f4fbd
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions .circleci/circle_urls.sh
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
BASEURL=https://output.circle-artifacts.com/output/job/${CIRCLE_WORKFLOW_JOB_ID}/artifacts/${CIRCLE_NODE_INDEX}/usrse.github.io
sed -i "8 s,.*,baseurl: $BASEURL,g" "_config.yml"
sed -i "7 s,.*,url: \"\",g" "_config.yml"
2 changes: 1 addition & 1 deletion _config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ lang: en
title: US-RSE
description: United States Research Software Engineer Association

url: ""
url: "https://us-rse.org"
baseurl: "" # for testing, also check .circleci/circle_urls.sh
title-img: /assets/img/main_logo_transparent.png # baseurl will be prepended
twitter-img: /assets/img/main_logo_transparent.png # url + baseurl will be prepended
Expand Down

0 comments on commit 41f4fbd

Please sign in to comment.