FIX Popover toggle

client/src/components/ActionMenu/ActionMenu.js

@@ -22,7 +22,15 @@ class ActionMenu extends PureComponent {
 
     // Force setting state to the end of the execution queue to clear a potential race condition
     // with entwine click handlers
-    window.setTimeout(() => this.setState((prevState) => ({ isOpen: !prevState.isOpen })), 0);
+    //
+    // eslint disable the next line which references this.state within setState()
+    // https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/no-access-state-in-setstate.md
+    // Following eslint guidelines this would be implemented as:
+    // window.setTimeout(() => this.setState((prevState) => ({ isOpen: !prevState.isOpen })), 0);
+    // However react ends up confused it's wrapped inside window.setTimeout()
+    // and it may end up setting state twice causing the toggle to open and then immediately close
+    // eslint-disable-next-line
+    window.setTimeout(() => this.setState({ isOpen: !this.state.isOpen }), 0);
   }
 
   render() {

client/src/components/PopoverField/PopoverField.js

@@ -43,7 +43,15 @@ class PopoverField extends Component {
 
     // Force setting state to the end of the execution queue to clear a potential race condition
     // with entwine click handlers
-    window.setTimeout(() => this.setState((prevState) => ({ isOpen: !prevState.isOpen }), toggleCallback), 0);
+    //
+    // eslint disable the next line which references this.state within setState()
+    // https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/no-access-state-in-setstate.md
+    // Following eslint guidelines this would be implemented as:
+    // window.setTimeout(() => this.setState((prevState) => ({ isOpen: !prevState.isOpen }), toggleCallback), 0);
+    // However react ends up confused it's wrapped inside window.setTimeout()
+    // and it may end up setting state twice causing the toggle to open and then immediately close
+    // eslint-disable-next-line
+    window.setTimeout(() => this.setState({ isOpen: !this.state.isOpen }, toggleCallback), 0);
   }
 
   render() {

client/src/components/PopoverOptionSet/PopoverOptionSetToggle.js

@@ -26,7 +26,15 @@ class PopoverOptionSetToggle extends Component {
   handleToggle() {
     // Force setting state to the end of the execution queue to clear a potential race condition
     // with entwine click handlers
-    window.setTimeout(() => this.setState((prevState) => ({ isOpen: !prevState.isOpen })), 0);
+    //
+    // eslint disable the next line which references this.state within setState()
+    // https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/no-access-state-in-setstate.md
+    // Following eslint guidelines this would be implemented as:
+    // window.setTimeout(() => this.setState((prevState) => ({ isOpen: !prevState.isOpen })), 0);
+    // However react ends up confused it's wrapped inside window.setTimeout()
+    // and it may end up setting state twice causing the toggle to open and then immediately close
+    // eslint-disable-next-line
+    window.setTimeout(() => this.setState({ isOpen: !this.state.isOpen }), 0);
   }
 
   render() {