FIX Popover toggle

creative-commoners · Aug 3, 2023 · ee30f31 · ee30f31
1 parent 177c9ad
commit ee30f31
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 4 deletions.
diff --git a/client/dist/js/bundle.js b/client/dist/js/bundle.js
diff --git a/client/src/components/ActionMenu/ActionMenu.js b/client/src/components/ActionMenu/ActionMenu.js
@@ -22,7 +22,10 @@ class ActionMenu extends PureComponent {
 
     // Force setting state to the end of the execution queue to clear a potential race condition
     // with entwine click handlers
-    window.setTimeout(() => this.setState((prevState) => ({ isOpen: !prevState.isOpen })), 0);
+    //
+    // ignore linting rule because following the recommended replacement caused behat failures
+    // eslint-disable-next-line react/no-access-state-in-setstate
+    window.setTimeout(() => this.setState({ isOpen: !this.state.isOpen }), 0);
   }
 
   render() {

diff --git a/client/src/components/PopoverField/PopoverField.js b/client/src/components/PopoverField/PopoverField.js
@@ -43,7 +43,10 @@ class PopoverField extends Component {
 
     // Force setting state to the end of the execution queue to clear a potential race condition
     // with entwine click handlers
-    window.setTimeout(() => this.setState((prevState) => ({ isOpen: !prevState.isOpen }), toggleCallback), 0);
+    //
+    // ignore linting rule because following the recommended replacement caused behat failures
+    // eslint-disable-next-line react/no-access-state-in-setstate
+    window.setTimeout(() => this.setState({ isOpen: !this.state.isOpen }, toggleCallback), 0);
   }
 
   render() {

diff --git a/client/src/components/PopoverOptionSet/PopoverOptionSetToggle.js b/client/src/components/PopoverOptionSet/PopoverOptionSetToggle.js
@@ -26,7 +26,10 @@ class PopoverOptionSetToggle extends Component {
   handleToggle() {
     // Force setting state to the end of the execution queue to clear a potential race condition
     // with entwine click handlers
-    window.setTimeout(() => this.setState((prevState) => ({ isOpen: !prevState.isOpen })), 0);
+    //
+    // ignore linting rule because following the recommended replacement caused behat failures
+    // eslint-disable-next-line react/no-access-state-in-setstate
+    window.setTimeout(() => this.setState({ isOpen: !this.state.isOpen }), 0);
   }
 
   render() {