-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernized plugin code #131
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce to CreativeCommons_TOT with src folder as the source folder to the plugin codebase susing autoload psr-4.
… WordPress plugin requirement
…ince it will not be called from WordPress PHP codebase directly.
…ision with other plugins
… in docker-compose.dev.yml
…n _construct method
Since plugin_dir_path will return a path with leading slash, referencing should start with assets and not /assets
Hi @possumbilities please I think you wanted to assign me elsewhere. The reviewed PR is #132 for #127 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #127 by @TimidRobot
Description
Technical details
For development purposes a docker-compose.dev.yml file was created with Mariadb and PhpMyadmin services.
I used 8701 as my outside port, you can use anyone that’s open and free on your host machine. And also set up the ip address where applicable.
On IP, the tot_mariadb_1 container IP address can be gotten by accessing the container, install iproute2 (done once) like this:
docker exec -it tot_mariadb_1 bash
then install iproute2apt-get update && apt-get install iproute2 -y
after which you can useip addr | grep global
to get its IP.After getting the files, for example from my repo
git clone github.com/onyijne/termination-of-transfer.git
Then cd to it and run
docker-compose -f docker-compose.dev.yml up —build
This should start the wp, mariadb and phpmyadmin services.
If you already have a mysql container running, you can just do
docker run --name wp-cont -e WORDPRESS_DB_HOST=host:port -e WORDPRESS_DB_USER=user -e WORDPRESS_DB_PASSWORD=pass -p 8701:80 -d wp-image
A working example
Tests
To run Result test on your machine type
chmod +x test/result-pdf.sh && test/result-pdf.sh 8701
where 8701 is the port number of your host machine.Screenshots
Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin