feat: Added API to delete connection, and added patch for multi-tenancy OOB connection #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… oob connection Signed-off-by: Sagar Khole <sagar.khole@ayanworks.com>
bhavanakarwade
requested review from
GHkrishna,
amitpadmani-awts and
ankita-p17
GHkrishna
requested changes
Jan 28, 2025
|
Can we also have a short description of the issue that the patch is solving? |
Signed-off-by: Sagar Khole <sagar.khole@ayanworks.com>
sagarkhole4
force-pushed
the
fix/multi-tenancy-oob-connection
branch
from
8af64b8 to
39a53f5
Compare
|
GHkrishna
approved these changes
Jan 28, 2025
tipusinghaw
approved these changes
Jan 28, 2025
| - .returnWhenIsConnected(connectionRecord.id, { timeoutMs }) | ||
| - .then((connectionRecord) => this.emitWithConnection(outOfBandRecord, connectionRecord, messages)) | ||
| - .catch((error) => { | ||
| + // this.connectionsApi |
There was a problem hiding this comment.
Suggested change
| + // this.connectionsApi | |
| + Remove the commented code if not necessary |
|
@sagarkhole4 if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When issuing credentials using the out-of-band protocol with connection reuse disabled or when establishing a new connection, the connection gets successfully established, but the credentials remain in the request-sent state indefinitely.
This issue does not occur when reusing an existing connection. In such cases, the credential issuance process transitions to the appropriate final state as expected.
Delete Connection Functionality:
Patch for Multitenancy OOB Connection:
Issue created on credo-ts Clicl here