Guard CREGEN against empty conformer groups #447
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduction
Example command taken from https://crest-lab.github.io/crest-docs/page/examples/qcg/example_5.html.
On
master(c39758d) this workflow aborts during the first CREGEN pass with:Any pure GFN‑FF QCG run that skips the RMSD/rotamer grouping step exhibits the same crash:
degenis never populated, yetcregen_conffiledereferencesxyz(:,:,degen(2,i)), so a zero index triggers the SIGSEGV.Summary
sortRMSDis false.cregen_conffileagainst invalid group indices so we never read outside[1, nall].Details
degen(:,i) = i(or a single zeroed entry when the ensemble is empty).degen(2,i)falls outside the valid index range before callingwrc0.Testing
c39758d) + xtb 6.6.1