Conversation
…be fixed now that we have a static shared model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI was previously failing due to two separate issues:
NSEntityDescriptionerrorsThese issues came from two different levels of parallelization:
✅ Fixes
EssentialFeedCacheIntegrationTeststarget, since it mutates shared state (file system).static let, ensuring it’s loaded only once in memory (instead of once per test target).❌ Removing the flag
The
-parallel-testing-enabled NOflag globally disables all forms of parallelization, including inter-target, which increases CI times. Since both issues have now been resolved at their root, the flag is no longer necessary.