Skip to content

Comments

ci: Remove parallelization flag from CI#5

Merged
crisfeim merged 1 commit intomainfrom
fix/ci
Apr 23, 2025
Merged

ci: Remove parallelization flag from CI#5
crisfeim merged 1 commit intomainfrom
fix/ci

Conversation

@crisfeim
Copy link
Owner

@crisfeim crisfeim commented Apr 23, 2025

CI was previously failing due to two separate issues:

  • SQLite I/O disk error
  • Ambiguous NSEntityDescription errors

These issues came from two different levels of parallelization:

  • Intra-target parallelization: test methods within the same target running in parallel.
  • Inter-target parallelization: test targets running in parallel (introduced with test plans).

✅ Fixes

  • The SQLite I/O error was fixed by disabling intra-target parallelization for the EssentialFeedCacheIntegrationTests target, since it mutates shared state (file system).
  • The NSEntityDescription ambiguity was fixed by making the Core Data model a static let, ensuring it’s loaded only once in memory (instead of once per test target).

❌ Removing the flag

The -parallel-testing-enabled NO flag globally disables all forms of parallelization, including inter-target, which increases CI times. Since both issues have now been resolved at their root, the flag is no longer necessary.

…be fixed now that we have a static shared model
@crisfeim crisfeim changed the title Remove parallelization flag from CI ci: Remove parallelization flag from CI Apr 23, 2025
@crisfeim crisfeim merged commit 187610f into main Apr 23, 2025
1 check passed
@crisfeim crisfeim deleted the fix/ci branch May 31, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant