Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mapping of certs to PPs broken due to CC URL change. #444

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

J08nY
Copy link
Member

@J08nY J08nY commented Oct 16, 2024

The PP links in the CSV/HTML are now slightly different than they were before. Since the PP dataset is static, it still has the old links. We use the links to match the PPs to the certs, hence that matching was broken with the change. This PR tries to fix the issue by mapping links to filenames before the matching is done.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.79%. Comparing base (c8c91a0) to head (3d887b3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #444      +/-   ##
==========================================
+ Coverage   67.77%   67.79%   +0.02%     
==========================================
  Files          62       62              
  Lines        7567     7568       +1     
==========================================
+ Hits         5128     5130       +2     
+ Misses       2439     2438       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@J08nY J08nY added bug Something isn't working cc Related to CC certification labels Oct 17, 2024
Copy link
Collaborator

@adamjanovsky adamjanovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks flawless, thanks 👍.

@adamjanovsky adamjanovsky merged commit 17af7f6 into main Oct 17, 2024
6 checks passed
@adamjanovsky adamjanovsky deleted the fix/pp-mapping-url-change branch October 17, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cc Related to CC certification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants