Update eslint (major) (#400)

* Update eslint * Update code to use stabilized APIs * Use absolute parser path eslint/eslint#11728 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Luiz Ferraz <luiz.ferraz@croct.com>
croct-tech · Aug 16, 2023 · d9587c7 · d9587c7
1 parent 87ddbae
commit d9587c7
Show file tree

Hide file tree

Showing 16 changed files with 818 additions and 295 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -37,30 +37,29 @@
   ],
   "dependencies": {
     "@rushstack/eslint-patch": "^1.1",
-    "@typescript-eslint/eslint-plugin": "^5.10",
-    "@typescript-eslint/experimental-utils": "^5.10",
+    "@typescript-eslint/eslint-plugin": "^6.4.0",
+    "@typescript-eslint/utils": "^6.4.0",
     "eslint-config-airbnb": "^19.0",
     "eslint-config-airbnb-base": "^15.0",
     "eslint-plugin-cypress": "^2.12",
     "eslint-plugin-eslint-comments": "^3.2.0",
     "eslint-plugin-import": "^2.25",
     "eslint-plugin-import-newlines": "^1.1",
     "eslint-plugin-jest": "^27.0.0",
-    "eslint-plugin-jest-dom": "^4.0",
+    "eslint-plugin-jest-dom": "^5.0.0",
     "eslint-plugin-jsx-a11y": "^6.5",
     "eslint-plugin-newline-destructuring": "^1.0.1",
     "eslint-plugin-no-smart-quotes": "^1.3",
     "eslint-plugin-react": "^7.28",
     "eslint-plugin-react-hooks": "^4.3",
-    "eslint-plugin-testing-library": "^5.0"
+    "eslint-plugin-testing-library": "^6.0.0"
   },
   "devDependencies": {
     "@types/eslint": "^8.4",
     "@types/jest": "^29.0.0",
     "@types/semver": "^7.3.12",
-    "@typescript-eslint/parser": "^5.10",
-    "@typescript-eslint/types": "^5.10",
-    "@typescript-eslint/utils": "^5.10",
+    "@typescript-eslint/parser": "^6.4.0",
+    "@typescript-eslint/types": "^6.4.0",
     "eslint": "^8.8",
     "eslint-plugin-eslint-plugin": "^5.0.0",
     "eslint-plugin-self": "^1.2.1",
@@ -69,7 +68,7 @@
     "typescript": "^5.0.0"
   },
   "peerDependencies": {
-    "@typescript-eslint/parser": ">= 5",
+    "@typescript-eslint/parser": ">= 6",
     "eslint": ">= 8"
   }
 }
diff --git a/src/rules/argument-spacing/index.test.ts b/src/rules/argument-spacing/index.test.ts
@@ -1,8 +1,8 @@
-import {ESLintUtils} from '@typescript-eslint/utils';
+import {RuleTester} from '@typescript-eslint/utils/ts-eslint';
 import {argumentSpacing} from './index';
 
-const ruleTester = new ESLintUtils.RuleTester({
-    parser: '@typescript-eslint/parser',
+const ruleTester = new RuleTester({
+    parser: require.resolve('@typescript-eslint/parser'),
 });
 
 ruleTester.run('argument-spacing', argumentSpacing, {

diff --git a/src/rules/argument-spacing/index.ts b/src/rules/argument-spacing/index.ts
@@ -1,4 +1,4 @@
-import {TSESTree} from '@typescript-eslint/experimental-utils';
+import {TSESTree} from '@typescript-eslint/utils';
 import {createRule} from '../createRule';
 
 export const argumentSpacing = createRule({
@@ -8,7 +8,7 @@ export const argumentSpacing = createRule({
         docs: {
             description: 'Enforces a surrounding line break before and after '
                 + 'the argument list in multiline functional calls.',
-            recommended: 'error',
+            recommended: 'recommended',
         },
         fixable: 'whitespace',
         schema: [],

diff --git a/src/rules/complex-expression-spacing/index.test.ts b/src/rules/complex-expression-spacing/index.test.ts
@@ -1,8 +1,8 @@
-import {ESLintUtils} from '@typescript-eslint/utils';
+import {RuleTester} from '@typescript-eslint/utils/ts-eslint';
 import {complexExpressionSpacing} from './index';
 
-const ruleTester = new ESLintUtils.RuleTester({
-    parser: '@typescript-eslint/parser',
+const ruleTester = new RuleTester({
+    parser: require.resolve('@typescript-eslint/parser'),
 });
 
 ruleTester.run('complex-expression-spacing', complexExpressionSpacing, {

diff --git a/src/rules/complex-expression-spacing/index.ts b/src/rules/complex-expression-spacing/index.ts
@@ -1,4 +1,4 @@
-import {TSESTree} from '@typescript-eslint/experimental-utils';
+import {TSESTree} from '@typescript-eslint/utils';
 import {createRule} from '../createRule';
 
 export const complexExpressionSpacing = createRule({
@@ -7,7 +7,7 @@ export const complexExpressionSpacing = createRule({
         type: 'suggestion',
         docs: {
             description: 'Enforces a surrounding line break in complex expression.',
-            recommended: 'error',
+            recommended: 'recommended',
         },
         fixable: 'whitespace',
         schema: [],

diff --git a/src/rules/createRule.ts b/src/rules/createRule.ts
@@ -1,4 +1,4 @@
-import {ESLintUtils} from '@typescript-eslint/experimental-utils';
+import {ESLintUtils} from '@typescript-eslint/utils';
 
 export const createRule = ESLintUtils.RuleCreator(
     name => `https://github.com/croct-tech/coding-standard-js/tree/master/docs/${name}.md`,

diff --git a/src/rules/jsx-attribute-spacing/index.test.ts b/src/rules/jsx-attribute-spacing/index.test.ts
@@ -1,8 +1,8 @@
-import {ESLintUtils} from '@typescript-eslint/utils';
+import {RuleTester} from '@typescript-eslint/utils/ts-eslint';
 import {jsxAttributeSpacing} from './index';
 
-const ruleTester = new ESLintUtils.RuleTester({
-    parser: '@typescript-eslint/parser',
+const ruleTester = new RuleTester({
+    parser: require.resolve('@typescript-eslint/parser'),
     parserOptions: {
         ecmaFeatures: {
             jsx: true,

diff --git a/src/rules/jsx-attribute-spacing/index.ts b/src/rules/jsx-attribute-spacing/index.ts
@@ -1,4 +1,4 @@
-import {TSESTree} from '@typescript-eslint/experimental-utils';
+import {TSESTree} from '@typescript-eslint/utils';
 import {createRule} from '../createRule';
 
 export const jsxAttributeSpacing = createRule({
@@ -7,7 +7,7 @@ export const jsxAttributeSpacing = createRule({
         type: 'suggestion',
         docs: {
             description: 'Enforces a surrounding line break in multiline JSX attributes.',
-            recommended: 'error',
+            recommended: 'recommended',
         },
         fixable: 'whitespace',
         schema: [],

diff --git a/src/rules/min-chained-call-depth/index.test.ts b/src/rules/min-chained-call-depth/index.test.ts
@@ -1,8 +1,8 @@
-import {ESLintUtils} from '@typescript-eslint/utils';
+import {RuleTester} from '@typescript-eslint/utils/ts-eslint';
 import {minChainedCallDepth} from './index';
 
-const ruleTester = new ESLintUtils.RuleTester({
-    parser: '@typescript-eslint/parser',
+const ruleTester = new RuleTester({
+    parser: require.resolve('@typescript-eslint/parser'),
     parserOptions: {
         ecmaFeatures: {
             jsx: true,

diff --git a/src/rules/min-chained-call-depth/index.ts b/src/rules/min-chained-call-depth/index.ts
@@ -1,5 +1,5 @@
-import {AST_TOKEN_TYPES, AST_NODE_TYPES, TSESTree} from '@typescript-eslint/experimental-utils';
-import {isCommentToken} from '@typescript-eslint/utils/dist/ast-utils';
+import {AST_TOKEN_TYPES, AST_NODE_TYPES, TSESTree} from '@typescript-eslint/utils';
+import {isCommentToken} from '@typescript-eslint/utils/ast-utils';
 import {createRule} from '../createRule';
 
 export const minChainedCallDepth = createRule({
@@ -8,7 +8,7 @@ export const minChainedCallDepth = createRule({
         type: 'layout',
         docs: {
             description: 'Enforces a minimum depth for multiline chained calls.',
-            recommended: 'error',
+            recommended: 'stylistic',
         },
         fixable: 'whitespace',
         schema: [

diff --git a/src/rules/newline-per-chained-call/index.test.ts b/src/rules/newline-per-chained-call/index.test.ts
@@ -1,8 +1,8 @@
-import {ESLintUtils} from '@typescript-eslint/utils';
+import {RuleTester} from '@typescript-eslint/utils/ts-eslint';
 import {newlinePerChainedCall} from './index';
 
-const ruleTester = new ESLintUtils.RuleTester({
-    parser: '@typescript-eslint/parser',
+const ruleTester = new RuleTester({
+    parser: require.resolve('@typescript-eslint/parser'),
     parserOptions: {
         ecmaFeatures: {
             jsx: true,

diff --git a/src/rules/newline-per-chained-call/index.ts b/src/rules/newline-per-chained-call/index.ts
@@ -1,5 +1,4 @@
-import {TSESTree} from '@typescript-eslint/experimental-utils';
-import {Expression} from '@typescript-eslint/types/dist/generated/ast-spec';
+import {TSESTree} from '@typescript-eslint/utils';
 import {createRule} from '../createRule';
 
 const LINEBREAK_MATCHER = /\r\n|[\r\n\u2028\u2029]/u;
@@ -10,7 +9,7 @@ export const newlinePerChainedCall = createRule({
         type: 'layout',
         docs: {
             description: 'Require a newline after each call in a method chain',
-            recommended: 'error',
+            recommended: 'recommended',
         },
         fixable: 'whitespace',
         schema: [
@@ -73,7 +72,7 @@ export const newlinePerChainedCall = createRule({
             ) {
                 const memberExpressions = [];
 
-                let currentNode: Expression = (
+                let currentNode: TSESTree.Expression = (
                     node.type === 'CallExpression'
                         ? node.callee
                         : node

diff --git a/src/rules/parameter-destructuring/index.test.ts b/src/rules/parameter-destructuring/index.test.ts
@@ -1,8 +1,8 @@
-import {ESLintUtils} from '@typescript-eslint/utils';
+import {RuleTester} from '@typescript-eslint/utils/ts-eslint';
 import {parameterDestructuring} from './index';
 
-const ruleTester = new ESLintUtils.RuleTester({
-    parser: '@typescript-eslint/parser',
+const ruleTester = new RuleTester({
+    parser: require.resolve('@typescript-eslint/parser'),
     parserOptions: {
         ecmaFeatures: {
             jsx: true,

diff --git a/src/rules/parameter-destructuring/index.ts b/src/rules/parameter-destructuring/index.ts
@@ -1,5 +1,5 @@
-import {AST_NODE_TYPES} from '@typescript-eslint/types';
-import {RuleFix} from '@typescript-eslint/utils/dist/ts-eslint';
+import {AST_NODE_TYPES} from '@typescript-eslint/utils';
+import {RuleFix} from '@typescript-eslint/utils/ts-eslint';
 import {createRule} from '../createRule';
 
 export const parameterDestructuring = createRule({
@@ -8,7 +8,7 @@ export const parameterDestructuring = createRule({
         type: 'layout',
         docs: {
             description: 'Prevent noisy destructuring on parameters',
-            recommended: 'error',
+            recommended: 'recommended',
         },
         hasSuggestions: true,
         schema: [],

diff --git a/tsconfig.json b/tsconfig.json
@@ -1,8 +1,8 @@
 {
   "compilerOptions": {
     "module": "CommonJS",
-    "target": "es6",
-    "moduleResolution": "Node",
+    "target": "ES2020",
+    "moduleResolution": "node16",
     "allowSyntheticDefaultImports": true,
     "resolveJsonModule": true,
     "noImplicitAny": true,
@@ -15,7 +15,7 @@
     "removeComments": false,
     "outDir": "dist",
     "downlevelIteration": true,
-    "declaration": true,
+    "declaration": false,
     "lib": ["es6"]
   },
   "include": [